Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add argument 'batch_mode' to argument object 'cloudwatch_logs' for 'aws_iot_topic_rule' resource #35444

Closed
mathiasornstrup opened this issue Jan 23, 2024 · 5 comments · Fixed by #36772
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service.
Milestone

Comments

@mathiasornstrup
Copy link

Description

As per the AWS Console:

Screenshot 2024-01-23 at 13 24 23

The boolean attribute 'batch_mode' is available when configuring aws iot topic rules to forward data to cloudwatch logs. This is however not available with terraform according to the docs:

https://registry.terraform.io/providers/hashicorp/aws/5.33.0/docs/resources/iot_topic_rule#:~:text=The%20cloudwatch_logs%20object%20takes%20the%20following%20arguments%3A.

My enhancement request is therefore to add batch_mode to the 'cloudwatch_logs' object argument.

Affected Resource(s) and/or Data Source(s)

  • aws_iot_topic_rule
    - cloudwatch_logs

Potential Terraform Configuration

resource "aws_iot_topic_rule" "rule" {
  name        = "MyRule"
  description = "Example rule"
  enabled     = true
  sql         = "SELECT * FROM 'topic/test'"
  sql_version = "2016-03-23"

  cloudwatch_logs {
    log_group_name = aws_iam_role.role.arn
    batch_mode = true 
    role_arn     = aws_iam_role.role.arn
  }
}

References

Schema-implementation:

Would you like to implement a fix?

None

@mathiasornstrup mathiasornstrup added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 23, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/iot Issues and PRs that pertain to the iot service. label Jan 23, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 23, 2024
@mathiasornstrup
Copy link
Author

edit: Potential Terraform Configuration

resource "aws_iot_topic_rule" "rule" {
  name        = "MyRule"
  description = "Example rule"
  enabled     = true
  sql         = "SELECT * FROM 'topic/test'"
  sql_version = "2016-03-23"

  cloudwatch_logs {
    log_group_name = "my_log_group"
    batch_mode = true 
    role_arn     = aws_iam_role.role.arn
  }
}

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 23, 2024
Copy link

github-actions bot commented Jul 3, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.57.0 milestone Jul 3, 2024
Copy link

github-actions bot commented Jul 5, 2024

This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Aug 7, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants