Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t - aws glue job #36770

Merged
merged 6 commits into from
Apr 16, 2024
Merged

t - aws glue job #36770

merged 6 commits into from
Apr 16, 2024

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Apr 6, 2024 •
edited
Loading

Description

Relations

Closes #33862

References

Output from Acceptance Testing

% make testacc TESTS=TestAccGlueJob_workerType PKG=glue
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueJob_workerType'  -timeout 360m
=== RUN   TestAccGlueJob_workerType
=== PAUSE TestAccGlueJob_workerType
=== CONT  TestAccGlueJob_workerType
--- PASS: TestAccGlueJob_workerType (99.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	118.157s

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. labels Apr 6, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 6, 2024
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Apr 6, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 8, 2024
@jar-b
Merge branch 'main' into r/aws_glue_job
495798d
@jar-b
r/aws_glue_job: number_of_workers and worker_type are optional/computed
811aef3 
Previously these arguments were optional only, but it appears the read operation can now return non-nil values for these attributes when `max_capacity` is set. Marking these as optional/computed prevents persistent differences (and fixes several failing acceptance tests).

```console
% make testacc PKG=glue TESTS=TestAccGlueJob_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueJob_'  -timeout 360m

--- PASS: TestAccGlueJob_rayJob (31.89s)
--- PASS: TestAccGlueJob_disappears (33.39s)
--- PASS: TestAccGlueJob_basicStreaming (36.27s)
--- PASS: TestAccGlueJob_basic (38.12s)
--- PASS: TestAccGlueJob_nonOverridableArguments (54.61s)
--- PASS: TestAccGlueJob_description (54.71s)
--- PASS: TestAccGlueJob_defaultArguments (54.78s)
--- PASS: TestAccGlueJob_maxCapacity (54.89s)
--- PASS: TestAccGlueJob_timeout (54.91s)
--- PASS: TestAccGlueJob_command (55.50s)
--- PASS: TestAccGlueJob_security (55.58s)
--- PASS: TestAccGlueJob_executionClass (55.72s)
--- PASS: TestAccGlueJob_streamingTimeout (55.78s)
--- PASS: TestAccGlueJob_maxRetries (56.43s)
--- PASS: TestAccGlueJob_executionProperty (56.49s)
--- PASS: TestAccGlueJob_notificationProperty (57.15s)
--- PASS: TestAccGlueJob_tags (63.00s)
--- PASS: TestAccGlueJob_glueVersion (63.46s)
--- PASS: TestAccGlueJob_pythonShell (73.20s)
--- PASS: TestAccGlueJob_workerType (79.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       84.990s
```
@jar-b
chore: changelog
5b4d557
jar-b
jar-b approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=glue TESTS=TestAccGlueJob_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueJob_'  -timeout 360m

--- PASS: TestAccGlueJob_rayJob (31.89s)
--- PASS: TestAccGlueJob_disappears (33.39s)
--- PASS: TestAccGlueJob_basicStreaming (36.27s)
--- PASS: TestAccGlueJob_basic (38.12s)
--- PASS: TestAccGlueJob_nonOverridableArguments (54.61s)
--- PASS: TestAccGlueJob_description (54.71s)
--- PASS: TestAccGlueJob_defaultArguments (54.78s)
--- PASS: TestAccGlueJob_maxCapacity (54.89s)
--- PASS: TestAccGlueJob_timeout (54.91s)
--- PASS: TestAccGlueJob_command (55.50s)
--- PASS: TestAccGlueJob_security (55.58s)
--- PASS: TestAccGlueJob_executionClass (55.72s)
--- PASS: TestAccGlueJob_streamingTimeout (55.78s)
--- PASS: TestAccGlueJob_maxRetries (56.43s)
--- PASS: TestAccGlueJob_executionProperty (56.49s)
--- PASS: TestAccGlueJob_notificationProperty (57.15s)
--- PASS: TestAccGlueJob_tags (63.00s)
--- PASS: TestAccGlueJob_glueVersion (63.46s)
--- PASS: TestAccGlueJob_pythonShell (73.20s)
--- PASS: TestAccGlueJob_workerType (79.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       84.990s

@jar-b
Copy link
Member

jar-b commented Apr 16, 2024

Thanks for your contribution, @nikhil-goenka! 👍

@jar-b jar-b merged commit a680053 into hashicorp:main Apr 16, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 16, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
@nikhil-goenka nikhil-goenka deleted the r/aws_glue_job branch June 16, 2024 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.46.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_glue_job new worker types
3 participants
@nikhil-goenka @jar-b @justinretzolk