feat: Add use_off_peak_window arg to auto_tune_options block for aws_opensearch_domain

[acwwat]

Description

This PR is to add a new use_off_peak_window argument to the auto_tune_options configuration block for the aws_opensearch_domain resource. To make this work, I had to remove Computed: true from the maintenance_schedule config block schema, otherwise it would keep loading the existing config blocks even though they are removed from the TF config in an update scenario.

Relations

Closes #33208

References

Referred to CreateDomain and UpdateDomainConfig for the specs and description.

Output from Acceptance Testing

$  make testacc TESTARGS="-run=TestAccOpenSearchDomain_autoTuneOptions" PKG=opensearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 20  -run=TestAccOpenSearchDomain_autoTuneOptions -timeout 360m
=== RUN   TestAccOpenSearchDomain_autoTuneOptions
=== PAUSE TestAccOpenSearchDomain_autoTuneOptions
=== CONT  TestAccOpenSearchDomain_autoTuneOptions
--- PASS: TestAccOpenSearchDomain_autoTuneOptions (1775.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/opensearch 1775.767s

$

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccOpenSearchDomain_autoTuneOptions\|TestAccOpenSearchDomain_basic' PKG=opensearch ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearch/... -v -count 1 -parallel 2  -run=TestAccOpenSearchDomain_autoTuneOptions\|TestAccOpenSearchDomain_basic -timeout 360m
=== RUN   TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN   TestAccOpenSearchDomain_autoTuneOptions
=== PAUSE TestAccOpenSearchDomain_autoTuneOptions
=== CONT  TestAccOpenSearchDomain_basic
=== CONT  TestAccOpenSearchDomain_autoTuneOptions
--- PASS: TestAccOpenSearchDomain_autoTuneOptions (1813.36s)
--- PASS: TestAccOpenSearchDomain_basic (2069.02s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	2077.928s

[ewbankkit]

@acwwat Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[xfournet]

@acwwat unfortunately it looks like this PR introduces this regression: #36291

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.