Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Opensearch auto_tune_options should support enabling/disabling autotune using the off-peak window #33208

Closed
rfein-hearst opened this issue Aug 28, 2023 · 3 comments · Fixed by #36067
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/opensearch Issues and PRs that pertain to the opensearch service.
Milestone

Comments

@rfein-hearst
Copy link

rfein-hearst commented Aug 28, 2023

Description

The auto_tune_options section of UpdateDomainConfig supports the UseOffPeakWindow option, which is also represented in the console. This option is not present in the auto_tune_options configuration block, and changing the state of it via the console/API doesn't result in any difference in the plan output by terraform.

Affected Resource(s) and/or Data Source(s)

  • aws_opensearch_domain

Potential Terraform Configuration

resource "aws_opensearch_domain" "example" {
  domain_name    = "example"
  engine_version = "Elasticsearch_7.10"

  cluster_config {
    instance_type = "r4.large.search"
  }

  tags = {
    Domain = "TestDomain"
 
  off_peak_window_options {
    enabled = true
    off_peak_window {
      window_start_time {
        hours   = 2
        minutes = 0
      }
    }
  }

  auto_tune_options {
    desired_state = "ENABLED"
    use_off_peak_window = true
  }
}

References

https://docs.aws.amazon.com/opensearch-service/latest/APIReference/API_UpdateDomainConfig.html

...
  "AutoTuneOptions": { 
      "DesiredState": "string",
      "MaintenanceSchedules": [ 
         { 
            "CronExpressionForRecurrence": "string",
            "Duration": { 
               "Unit": "string",
               "Value": number
            },
            "StartAt": number
         }
      ],
      "RollbackOnDisable": "string",
      "UseOffPeakWindow": boolean
   },

Would you like to implement a fix?

No

@rfein-hearst rfein-hearst added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 28, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/opensearch Issues and PRs that pertain to the opensearch service. label Aug 28, 2023
@rfein-hearst rfein-hearst changed the title [Enhancement]: Opensearch auto_tune_options should support enabling/disabling the off-peak window [Enhancement]: Opensearch auto_tune_options should support enabling/disabling autotune using the off-peak window Aug 28, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 28, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 30, 2023
@github-actions github-actions bot added this to the v5.40.0 milestone Mar 5, 2024
Copy link

github-actions bot commented Mar 7, 2024

This functionality has been released in v5.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Apr 7, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/opensearch Issues and PRs that pertain to the opensearch service.
Projects
None yet
2 participants