[Enhancement] : Validation function for RDS performance_insights_retention_period attribute

[Jebaseelanravi]

Description

The valid values for the performance insights retention period are 7, 731 (2 years) or a multiple of 31. This is properly documented. However, in case of an invalid value terraform plan does not complain, you will get the error only after trying to apply the change.

Terraform will perform the following actions:

  # module.db.aws_db_instance.this will be updated in-place
  ~ resource "aws_db_instance" "this" {
        id                                    = "db-XXXXXX"
      ~ performance_insights_retention_period = 7 -> 8
        tags                                  = {
            "Name" = "db-dev"
        }
        # (56 unchanged attributes hidden)
    }

Relations

Closes #34342

References

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance#performance_insights_retention_period

Output from Acceptance Testing

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSInstance_PerformanceInsights\|TestAccRDSInstance_basic' PKG=rds ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/rds/... -v -count 1 -parallel 3  -run=TestAccRDSInstance_PerformanceInsights\|TestAccRDSInstance_basic -timeout 360m
=== RUN   TestAccRDSInstance_basic
=== PAUSE TestAccRDSInstance_basic
=== RUN   TestAccRDSInstance_PerformanceInsights_disabledToEnabled
=== PAUSE TestAccRDSInstance_PerformanceInsights_disabledToEnabled
=== RUN   TestAccRDSInstance_PerformanceInsights_enabledToDisabled
=== PAUSE TestAccRDSInstance_PerformanceInsights_enabledToDisabled
=== RUN   TestAccRDSInstance_PerformanceInsights_kmsKeyID
=== PAUSE TestAccRDSInstance_PerformanceInsights_kmsKeyID
=== RUN   TestAccRDSInstance_PerformanceInsights_retentionPeriod
=== PAUSE TestAccRDSInstance_PerformanceInsights_retentionPeriod
=== CONT  TestAccRDSInstance_basic
=== CONT  TestAccRDSInstance_PerformanceInsights_kmsKeyID
=== CONT  TestAccRDSInstance_PerformanceInsights_enabledToDisabled
--- PASS: TestAccRDSInstance_basic (510.57s)
=== CONT  TestAccRDSInstance_PerformanceInsights_disabledToEnabled
--- PASS: TestAccRDSInstance_PerformanceInsights_enabledToDisabled (857.28s)
=== CONT  TestAccRDSInstance_PerformanceInsights_retentionPeriod
--- PASS: TestAccRDSInstance_PerformanceInsights_kmsKeyID (1037.58s)
--- PASS: TestAccRDSInstance_PerformanceInsights_disabledToEnabled (726.33s)
--- PASS: TestAccRDSInstance_PerformanceInsights_retentionPeriod (785.40s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1654.292s

[ewbankkit]

@Jebaseelanravi Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.