Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: cognito_user_group import groups with '/' #35491

Closed
frediana opened this issue Jan 25, 2024 · 4 comments · Fixed by #35501
Closed

[Bug]: cognito_user_group import groups with '/' #35491

frediana opened this issue Jan 25, 2024 · 4 comments · Fixed by #35501
Labels
bug Addresses a defect in current functionality. service/cognitoidp Issues and PRs that pertain to the cognitoidp service.
Milestone

Comments

@frediana
Copy link
Contributor

frediana commented Jan 25, 2024

Terraform Core Version

1.7.0

AWS Provider Version

5.33.0

Affected Resource(s)

cognito_user_group

Expected Behavior

Given a perfectly valid existing cognito user group name "foo/bar"

I can not import it using an import block:

import {
id = "eu-west-1_xxxx/foo/bar"
to = aws_cognito_user_group.foo
}

Actual Behavior

Impossible to import it.

Relevant Error/Panic Output Snippet

Error importing Cognito User Group. Must specify user_pool_id/group_name

Terraform Configuration Files

resource "aws_cognito_user_group" "foo" {
name = "foo/bar"
user_pool_id = "eu-west-1_xxxx"
}

Steps to Reproduce

create an import.tf file and try to import an existing cognito group

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

Yes, I guess issue is located here: https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/cognitoidp/user_group.go#L183 the split doe. The if statement is maybe not relevant, and we should just split the string by '/' starting from the first occurence.

I would be happy to contribute and implement the fix if confirmed.

@frediana frediana added the bug Addresses a defect in current functionality. label Jan 25, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/cognitoidp Issues and PRs that pertain to the cognitoidp service. label Jan 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 25, 2024
frediana added a commit to frediana/terraform-provider-aws that referenced this issue Jan 26, 2024
@frediana
Copy link
Contributor Author

Here a fix proposal: #35501

@frediana frediana mentioned this issue Jan 26, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 26, 2024
ewbankkit added a commit that referenced this issue Jan 31, 2024
@github-actions github-actions bot added this to the v5.35.0 milestone Jan 31, 2024
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/cognitoidp Issues and PRs that pertain to the cognitoidp service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants