Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source aws_cognito_identity_pool #33053

Merged

Conversation

drewmullen
Copy link
Collaborator

@drewmullen drewmullen commented Aug 16, 2023

Description

Relations

Closes #32970

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccCognitoIdentityPoolDataSource_ PKG=cognitoidentity
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidentity/... -v -count 1 -parallel 20 -run='TestAccCognitoIdentityPoolDataSource_'  -timeout 180m
=== RUN   TestAccCognitoIdentityPoolDataSource_basic
=== PAUSE TestAccCognitoIdentityPoolDataSource_basic
=== RUN   TestAccCognitoIdentityPoolDataSource_openidConnectProviderARNs
=== PAUSE TestAccCognitoIdentityPoolDataSource_openidConnectProviderARNs
=== RUN   TestAccCognitoIdentityPoolDataSource_cognitoIdentityProviders
=== PAUSE TestAccCognitoIdentityPoolDataSource_cognitoIdentityProviders
=== RUN   TestAccCognitoIdentityPoolDataSource_samlProviderARNs
=== PAUSE TestAccCognitoIdentityPoolDataSource_samlProviderARNs
=== RUN   TestAccCognitoIdentityPoolDataSource_tags
=== PAUSE TestAccCognitoIdentityPoolDataSource_tags
=== CONT  TestAccCognitoIdentityPoolDataSource_basic
=== CONT  TestAccCognitoIdentityPoolDataSource_samlProviderARNs
=== CONT  TestAccCognitoIdentityPoolDataSource_cognitoIdentityProviders
=== CONT  TestAccCognitoIdentityPoolDataSource_tags
=== CONT  TestAccCognitoIdentityPoolDataSource_openidConnectProviderARNs
--- PASS: TestAccCognitoIdentityPoolDataSource_tags (16.03s)
--- PASS: TestAccCognitoIdentityPoolDataSource_basic (16.16s)
--- PASS: TestAccCognitoIdentityPoolDataSource_openidConnectProviderARNs (16.44s)
--- PASS: TestAccCognitoIdentityPoolDataSource_cognitoIdentityProviders (16.47s)
--- PASS: TestAccCognitoIdentityPoolDataSource_samlProviderARNs (16.81s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity    18.604s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. labels Aug 16, 2023
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Aug 16, 2023
@drewmullen drewmullen force-pushed the f-cognito_identity_pool_data_source branch from 980c7e7 to 54f1de8 Compare August 17, 2023 12:44
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 17, 2023
@drewmullen drewmullen changed the title [WIP]: new data source [WIP]: new data source aws_cognito_identity_pool Aug 17, 2023
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. generators Relates to code generators. and removed size/L Managed by automation to categorize the size of a PR. labels Aug 17, 2023
@drewmullen drewmullen changed the title [WIP]: new data source aws_cognito_identity_pool New data source aws_cognito_identity_pool Aug 17, 2023
@drewmullen drewmullen changed the title New data source aws_cognito_identity_pool [WIP] New data source aws_cognito_identity_pool Aug 17, 2023
@drewmullen drewmullen changed the title [WIP] New data source aws_cognito_identity_pool New data source aws_cognito_identity_pool Aug 18, 2023
@drewmullen drewmullen force-pushed the f-cognito_identity_pool_data_source branch from 6d9ebce to 177e8a8 Compare August 18, 2023 12:53
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewbankkit ewbankkit self-assigned this Sep 11, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 11, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCognitoIdentityPoolDataSource_' PKG=cognitoidentity ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cognitoidentity/... -v -count 1 -parallel 3  -run=TestAccCognitoIdentityPoolDataSource_ -timeout 180m
=== RUN   TestAccCognitoIdentityPoolDataSource_basic
=== PAUSE TestAccCognitoIdentityPoolDataSource_basic
=== RUN   TestAccCognitoIdentityPoolDataSource_openidConnectProviderARNs
=== PAUSE TestAccCognitoIdentityPoolDataSource_openidConnectProviderARNs
=== RUN   TestAccCognitoIdentityPoolDataSource_cognitoIdentityProviders
=== PAUSE TestAccCognitoIdentityPoolDataSource_cognitoIdentityProviders
=== RUN   TestAccCognitoIdentityPoolDataSource_samlProviderARNs
=== PAUSE TestAccCognitoIdentityPoolDataSource_samlProviderARNs
=== RUN   TestAccCognitoIdentityPoolDataSource_supportedLoginProviders
=== PAUSE TestAccCognitoIdentityPoolDataSource_supportedLoginProviders
=== RUN   TestAccCognitoIdentityPoolDataSource_tags
=== PAUSE TestAccCognitoIdentityPoolDataSource_tags
=== CONT  TestAccCognitoIdentityPoolDataSource_basic
=== CONT  TestAccCognitoIdentityPoolDataSource_tags
=== CONT  TestAccCognitoIdentityPoolDataSource_supportedLoginProviders
--- PASS: TestAccCognitoIdentityPoolDataSource_basic (26.20s)
=== CONT  TestAccCognitoIdentityPoolDataSource_cognitoIdentityProviders
--- PASS: TestAccCognitoIdentityPoolDataSource_supportedLoginProviders (26.21s)
=== CONT  TestAccCognitoIdentityPoolDataSource_openidConnectProviderARNs
--- PASS: TestAccCognitoIdentityPoolDataSource_tags (26.26s)
=== CONT  TestAccCognitoIdentityPoolDataSource_samlProviderARNs
--- PASS: TestAccCognitoIdentityPoolDataSource_openidConnectProviderARNs (26.91s)
--- PASS: TestAccCognitoIdentityPoolDataSource_cognitoIdentityProviders (27.10s)
--- PASS: TestAccCognitoIdentityPoolDataSource_samlProviderARNs (27.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidentity	58.949s

@ewbankkit
Copy link
Contributor

@drewmullen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a0364dd into hashicorp:main Sep 11, 2023
60 checks passed
@github-actions github-actions bot added this to the v5.17.0 milestone Sep 11, 2023
@YakDriver YakDriver modified the milestones: v5.17.0, v5.16.2 Sep 11, 2023
@github-actions
Copy link

This functionality has been released in v5.16.2 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
@drewmullen drewmullen deleted the f-cognito_identity_pool_data_source branch October 26, 2023 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-data-source Introduces a new data source. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New]: Data source aws_cognito_identity_pool
5 participants