aws_dms_s3_endpoint Resource Adds add_trailing_padding_character = false

[grifonas]

Description

Hi,
It appears that the aws_dms_s3_endpoint resource adds add_trailing_padding_character=false to the JSON settings of the endpoint. However this option is not supported in replication instances below the version 3.4.7. This results in DMS errors.
It appears that it's not enough to set add_trailing_padding_character to false. The option add_trailing_padding_character should not be present at all.
Is there a way to work around this?

References

No response

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[sodle]

I believe this can be fixed by changing the Get call here to a GetOk. I'm verifying that assumption as we speak.

This will prevent Terraform from inserting a false value for this option when it is not specified for a resource. It will instead rely on AWS's default behavior, which also defaults to false. Therefore, this should have no side effects apart from fixing the error.

I'll note that the underlying DMS limitation is fixed in engine version 3.4.7. Engine versions 3.4.5 and earlier are already deprecated, and 3.4.6 will be deprecated in January of 2024 [source, requires an AWS login]. After that point, this issue will no longer be reproducible.

[github-actions]

This functionality has been released in v5.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.