-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add placement group to AWS Batch compute_resources #32200
Add placement group to AWS Batch compute_resources #32200
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
* afaict the github-actions bot advice to "remove any changes to the CHANGELOG.md" file conflicts with advice on https://hashicorp.github.io/terraform-provider-aws/raising-a-pull-request/ to "Create a changelog entry following the process"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @bruceadowns 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccBatchComputeEnvironment_ec2ConfigurationPlacementGroup\|TestAccBatchComputeEnvironment_createEC2\|TestAccBatchComputeEnvironment_basic' PKG=batch ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/batch/... -v -count 1 -parallel 2 -run=TestAccBatchComputeEnvironment_ec2ConfigurationPlacementGroup\|TestAccBatchComputeEnvironment_createEC2\|TestAccBatchComputeEnvironment_basic -timeout 180m
=== RUN TestAccBatchComputeEnvironment_basic
=== PAUSE TestAccBatchComputeEnvironment_basic
=== RUN TestAccBatchComputeEnvironment_createEC2
=== PAUSE TestAccBatchComputeEnvironment_createEC2
=== RUN TestAccBatchComputeEnvironment_ec2ConfigurationPlacementGroup
=== PAUSE TestAccBatchComputeEnvironment_ec2ConfigurationPlacementGroup
=== RUN TestAccBatchComputeEnvironment_createEC2WithoutComputeResources
=== PAUSE TestAccBatchComputeEnvironment_createEC2WithoutComputeResources
=== CONT TestAccBatchComputeEnvironment_basic
=== CONT TestAccBatchComputeEnvironment_ec2ConfigurationPlacementGroup
--- PASS: TestAccBatchComputeEnvironment_basic (47.61s)
=== CONT TestAccBatchComputeEnvironment_createEC2
--- PASS: TestAccBatchComputeEnvironment_ec2ConfigurationPlacementGroup (66.91s)
=== CONT TestAccBatchComputeEnvironment_createEC2WithoutComputeResources
--- PASS: TestAccBatchComputeEnvironment_createEC2WithoutComputeResources (15.81s)
--- PASS: TestAccBatchComputeEnvironment_createEC2 (47.90s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/batch 101.541s
@bruceadowns Thanks for the contribution 🎉 👏. |
Thanks for the PR cleanup @ewbankkit! |
This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #31457
References
Output from Acceptance Testing