Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support Placement Group for AWS Batch Compute Environment Resource #31457

Closed
rileyhun opened this issue May 18, 2023 · 4 comments · Fixed by #32200
Closed

[Enhancement]: Support Placement Group for AWS Batch Compute Environment Resource #31457

rileyhun opened this issue May 18, 2023 · 4 comments · Fixed by #32200
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/batch Issues and PRs that pertain to the batch service.
Milestone

Comments

@rileyhun
Copy link

rileyhun commented May 18, 2023

Description

We would like to do multi-node parallel batch jobs using AWS Batch, and it would be nice to be able to use placement groups with the aws_batch_compute_environment. The advantage of a placement group in this context is that instances are placed in close proximity for improved network performance and reduced latency, and this is necessary for distributed and parallel computing workloads. This is supported when creating a compute environment from the AWS Console, but seems to be missing in the terraform aws provider.

Affected Resource(s) and/or Data Source(s)

  • aws_batch_compute_environment

Potential Terraform Configuration

resource "aws_batch_compute_environment" "this" {
  placement_group = aws_placement_group.pg.id
}

References

No response

Would you like to implement a fix?

None

@rileyhun rileyhun added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels May 18, 2023
@github-actions github-actions bot added the service/batch Issues and PRs that pertain to the batch service. label May 18, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 18, 2023
@bruceadowns
Copy link
Contributor

I am putting together a PR today on this issue.

The solution will look like:

resource "aws_placement_group" "sample" {
  name     = "sample-placement-group"
  strategy = "cluster"
}

resource "aws_batch_compute_environment" "sample" {
  compute_environment_name = "sample"

  compute_resources {
    instance_role = aws_iam_instance_profile.ecs_instance_role.arn
    instance_type = ["optimal"]

    max_vcpus = 1
    placement_group = aws_placement_group.sample.name
...

bruceadowns added a commit to bruceadowns/terraform-provider-aws that referenced this issue Jun 23, 2023
@github-actions github-actions bot added this to the v5.6.0 milestone Jun 28, 2023
@github-actions
Copy link

This functionality has been released in v5.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/batch Issues and PRs that pertain to the batch service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants