-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Check the organization ID match with API Output #31796
Fix: Check the organization ID match with API Output #31796
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccOrganizations_serial/^Organization$$' PKG=organizations
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/organizations/... -v -count 1 -parallel 20 -run=TestAccOrganizations_serial/^Organization$ -timeout 180m
=== RUN TestAccOrganizations_serial
=== PAUSE TestAccOrganizations_serial
=== CONT TestAccOrganizations_serial
=== RUN TestAccOrganizations_serial/Organization
=== RUN TestAccOrganizations_serial/Organization/FeatureSet_Update
=== RUN TestAccOrganizations_serial/Organization/DataSource_basic
=== RUN TestAccOrganizations_serial/Organization/DataSource_delegatedAdministrator
acctest.go:804: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN TestAccOrganizations_serial/Organization/basic
=== RUN TestAccOrganizations_serial/Organization/AwsServiceAccessPrincipals
=== RUN TestAccOrganizations_serial/Organization/EnabledPolicyTypes
=== RUN TestAccOrganizations_serial/Organization/FeatureSet_Basic
=== RUN TestAccOrganizations_serial/Organization/FeatureSet_ForcesNew
=== RUN TestAccOrganizations_serial/Organization/DataSource_memberAccount
--- PASS: TestAccOrganizations_serial (359.34s)
--- PASS: TestAccOrganizations_serial/Organization (359.34s)
--- PASS: TestAccOrganizations_serial/Organization/FeatureSet_Update (40.78s)
--- PASS: TestAccOrganizations_serial/Organization/DataSource_basic (22.27s)
--- SKIP: TestAccOrganizations_serial/Organization/DataSource_delegatedAdministrator (0.00s)
--- PASS: TestAccOrganizations_serial/Organization/basic (24.49s)
--- PASS: TestAccOrganizations_serial/Organization/AwsServiceAccessPrincipals (57.17s)
--- PASS: TestAccOrganizations_serial/Organization/EnabledPolicyTypes (150.09s)
--- PASS: TestAccOrganizations_serial/Organization/FeatureSet_Basic (23.39s)
--- PASS: TestAccOrganizations_serial/Organization/FeatureSet_ForcesNew (41.05s)
--- PASS: TestAccOrganizations_serial/Organization/DataSource_memberAccount (17.95s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/organizations 364.095s
@sousmangoosta Thanks for the contribution 🎉 👏. |
…ade private and exported as "test-only".
This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
When doing an import of an organization, we provide an ID that can be different to the real one, and stored in the state without any comparison.
Relations
Closes #31783