Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_organizations_organization resource import doesn't validate input organization id. #31783

Closed
obeliskm opened this issue Jun 6, 2023 · 3 comments · Fixed by #31796
Labels
bug Addresses a defect in current functionality. service/organizations Issues and PRs that pertain to the organizations service.
Milestone

Comments

@obeliskm
Copy link

obeliskm commented Jun 6, 2023

Terraform Core Version

1.3.9

AWS Provider Version

4.67.0

Affected Resource(s)

resource "aws_organizations_organization" "foo" {}

Expected Behavior

If I import an AWS Organization into my state, then I'd expect it to refuse to import an invalid/non-existent organization id, or to complain loudly at the next apply that the id supplied doesn't match the current organization id.

Actual Behavior

It doesn't seem to matter what you specify as an id, the input succeeds, and you can then use the organization resource elsewhere in the config.

Where things get confusing is that the id returned by the resource continues to be whatever you supplied to the import, so you get baffling inconsistencies between data and resource (see example below)

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

If I add config for an Organization resource,

resource "aws_organizations_organization" "foo" {
  aws_service_access_principals = var.service_access_principals
  enabled_policy_types = [
    "SERVICE_CONTROL_POLICY",
  ]
  feature_set = "ALL"
}

and then import the current Org into state with a nonsense id

terraform import aws_organizations_organization.foo tada

then apply this tf code

data "aws_organizations_organization" "bar" {}

output "data_id" {
  value = data.aws_organizations_organization.bar.id
}

output "res_id" {
  value = aws_organizations_organization.foo.id
}

then I get this output:

  + data_id      = "o-6abcdeabcd"
  + res_id       = "tada"

Steps to Reproduce

normal terraform import

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@obeliskm obeliskm added bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/organizations Issues and PRs that pertain to the organizations service. label Jun 6, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jun 7, 2023
@github-actions github-actions bot added this to the v5.13.0 milestone Aug 11, 2023
@github-actions
Copy link

This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/organizations Issues and PRs that pertain to the organizations service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants