-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom_headers to aws_amplify_app #31561
Add custom_headers to aws_amplify_app #31561
Conversation
Community NoteVoting for Prioritization
For Submitters
|
@ewbankkit Anything stopping from this getting merged and released? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAmplify_serial/App' PKG=amplify
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/amplify/... -v -count 1 -parallel 20 -run=TestAccAmplify_serial/App -timeout 360m
=== RUN TestAccAmplify_serial
=== PAUSE TestAccAmplify_serial
=== CONT TestAccAmplify_serial
=== RUN TestAccAmplify_serial/App
=== RUN TestAccAmplify_serial/App/BasicAuthCredentials
app_test.go:250: Step 1/4 error: Check failed: Check 2/3 error: aws_amplify_app.test: Attribute 'basic_auth_credentials' expected "dXNlcm5hbWUxOnBhc3N3b3JkMQ==", got "dXNlcm5hbWUxOkh0WmtDZHNCNWdQc2Q4N1JLZGVhQmc9PXx8U3ZaaUtHODlVTjNrVmlGbFpiV3lUK3ByTDZFcmJrc0FWTi8zT3ZWb0M2RT0="
=== RUN TestAccAmplify_serial/App/Description
=== RUN TestAccAmplify_serial/App/EnvironmentVariables
=== RUN TestAccAmplify_serial/App/IamServiceRole
=== RUN TestAccAmplify_serial/App/Repository
app_test.go:559: Environment variable AMPLIFY_GITHUB_ACCESS_TOKEN is not set
=== RUN TestAccAmplify_serial/App/basic
=== RUN TestAccAmplify_serial/App/disappears
=== RUN TestAccAmplify_serial/App/tags
=== RUN TestAccAmplify_serial/App/Name
=== RUN TestAccAmplify_serial/App/AutoBranchCreationConfig
app_test.go:153: Step 2/5 error: Check failed: Check 3/16 error: aws_amplify_app.test: Attribute 'auto_branch_creation_config.0.basic_auth_credentials' expected "dXNlcm5hbWUxOnBhc3N3b3JkMQ==", got "dXNlcm5hbWUxOnV2UEJVaitjQ3hUem9FaVFwQURGZkE9PXx8cGdGak9oUnJtaXE1NmVjOWh2S3UzcCtybzd4Vk1iSzBCMmtSd1FGaG53dz0="
=== RUN TestAccAmplify_serial/App/BuildSpec
=== RUN TestAccAmplify_serial/App/CustomRules
--- FAIL: TestAccAmplify_serial (483.08s)
--- FAIL: TestAccAmplify_serial/App (483.08s)
--- FAIL: TestAccAmplify_serial/App/BasicAuthCredentials (12.53s)
--- PASS: TestAccAmplify_serial/App/Description (57.47s)
--- PASS: TestAccAmplify_serial/App/EnvironmentVariables (56.64s)
--- PASS: TestAccAmplify_serial/App/IamServiceRole (57.87s)
--- SKIP: TestAccAmplify_serial/App/Repository (0.00s)
--- PASS: TestAccAmplify_serial/App/basic (28.69s)
--- PASS: TestAccAmplify_serial/App/disappears (23.40s)
--- PASS: TestAccAmplify_serial/App/tags (59.44s)
--- PASS: TestAccAmplify_serial/App/Name (43.45s)
--- FAIL: TestAccAmplify_serial/App/AutoBranchCreationConfig (26.84s)
--- PASS: TestAccAmplify_serial/App/BuildSpec (57.69s)
--- PASS: TestAccAmplify_serial/App/CustomRules (59.05s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/amplify 488.617s
FAIL
make: *** [testacc] Error 1
Failures are unrelated to this change.
@Maddog2050 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add custom_headers to the aws_amplify_app resource
Relations
Closes #31560
References
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-amplify-app.html
https://docs.aws.amazon.com/amplify/latest/userguide/custom-headers.html