Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add custom_headers to aws_amplify_app #31560

Closed
Maddog2050 opened this issue May 24, 2023 · 3 comments · Fixed by #31561
Closed

[Enhancement]: Add custom_headers to aws_amplify_app #31560

Maddog2050 opened this issue May 24, 2023 · 3 comments · Fixed by #31561
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/amplify Issues and PRs that pertain to the amplify service.
Milestone

Comments

@Maddog2050
Copy link
Contributor

Description

Add custom_headers to the aws_amplify_app resource so that custom headers can be specified with Terraform.

Affected Resource(s) and/or Data Source(s)

  • aws_amplify_app

Potential Terraform Configuration

resource "aws_amplify_app" "example" {
  name = "example"

  custom_headers = <<-EOT
    customHeaders:
      - pattern: '**'
        headers:
          - key: 'Strict-Transport-Security'
            value: 'max-age=31536000; includeSubDomains'
          - key: 'X-Frame-Options'
            value: 'SAMEORIGIN'
          - key: 'X-XSS-Protection'
            value: '1; mode=block'
          - key: 'X-Content-Type-Options'
            value: 'nosniff'
          - key: 'Content-Security-Policy'
            value: "default-src 'self'"
  EOT
}

References

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-amplify-app.html
https://docs.aws.amazon.com/amplify/latest/userguide/custom-headers.html

Would you like to implement a fix?

Yes

@Maddog2050 Maddog2050 added enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels May 24, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/amplify Issues and PRs that pertain to the amplify service. label May 24, 2023
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label May 24, 2023
@github-actions github-actions bot added this to the v5.24.0 milestone Oct 31, 2023
Copy link

github-actions bot commented Nov 2, 2023

This functionality has been released in v5.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Dec 3, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/amplify Issues and PRs that pertain to the amplify service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants