Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/appsync_graphql_api - add visibility argument #31369

Merged
merged 15 commits into from
May 30, 2023
Merged

r/appsync_graphql_api - add visibility argument #31369

merged 15 commits into from
May 30, 2023

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented May 12, 2023 •
edited by ewbankkit
Loading

Description

Adds the visibility argument to support Private APIs.

Announcement.

Relations

Closes #16929.
Closes #16814.

Output from Acceptance Testing

$ make testacc TESTS=TestAccAppSync_serial/GraphQLAPI/visibility  PKG=appsync

        --- PASS: TestAccAppSync_serial/GraphQLAPI/basic (27.41s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/visibility (25.83s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/appsync Issues and PRs that pertain to the appsync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels May 12, 2023
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 12, 2023
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels May 12, 2023
@ewbankkit
Fix typo.
b1721f6
@ewbankkit
Merge branch 'main' into HEAD
9d2f36b 
# Conflicts:
#	internal/service/appsync/graphql_api_test.go
ewbankkit
ewbankkit approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppSync_serial/GraphQLAPI' PKG=appsync
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appsync/... -v -count 1 -parallel 20  -run=TestAccAppSync_serial/GraphQLAPI -timeout 180m
=== RUN   TestAccAppSync_serial
=== PAUSE TestAccAppSync_serial
=== CONT  TestAccAppSync_serial
=== RUN   TestAccAppSync_serial/GraphQLAPI
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsLambda
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_multiple
=== RUN   TestAccAppSync_serial/GraphQLAPI/disappears
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_openIDConnect
=== RUN   TestAccAppSync_serial/GraphQLAPI/Log_excludeVerboseContent
=== RUN   TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_identityValidationExpression
=== RUN   TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerResultTtlInSeconds
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_apiKey
=== RUN   TestAccAppSync_serial/GraphQLAPI/xrayEnabled
=== RUN   TestAccAppSync_serial/GraphQLAPI/name
=== RUN   TestAccAppSync_serial/GraphQLAPI/schema
=== RUN   TestAccAppSync_serial/GraphQLAPI/authenticationType
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_apiKey
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_amazonCognitoUserPools
=== RUN   TestAccAppSync_serial/GraphQLAPI/log
=== RUN   TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_authTTL
=== RUN   TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_iatTTL
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_cognitoUserPools
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_openIDConnect
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsIAM
=== RUN   TestAccAppSync_serial/GraphQLAPI/UserPool_awsRegion
=== RUN   TestAccAppSync_serial/GraphQLAPI/tags
=== RUN   TestAccAppSync_serial/GraphQLAPI/Log_fieldLogLevel
=== RUN   TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_clientID
=== RUN   TestAccAppSync_serial/GraphQLAPI/UserPool_defaultAction
=== RUN   TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsIAM
=== RUN   TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsLambda
=== RUN   TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_issuer
=== RUN   TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerUri
=== RUN   TestAccAppSync_serial/GraphQLAPI/visibility
=== RUN   TestAccAppSync_serial/GraphQLAPI/basic
--- PASS: TestAccAppSync_serial (935.01s)
    --- PASS: TestAccAppSync_serial/GraphQLAPI (935.01s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsLambda (44.75s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_multiple (43.47s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/disappears (12.90s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_openIDConnect (17.32s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/Log_excludeVerboseContent (30.49s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_identityValidationExpression (57.15s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerResultTtlInSeconds (77.33s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_apiKey (17.72s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/xrayEnabled (26.56s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/name (26.38s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/schema (32.99s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/authenticationType (29.17s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_apiKey (19.07s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_amazonCognitoUserPools (20.46s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/log (18.75s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_authTTL (29.54s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_iatTTL (28.72s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_cognitoUserPools (19.62s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_openIDConnect (17.46s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsIAM (17.43s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/UserPool_awsRegion (31.50s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/tags (39.97s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/Log_fieldLogLevel (40.78s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_clientID (30.47s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/UserPool_defaultAction (34.53s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AdditionalAuthentication_awsIAM (19.75s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/AuthenticationType_awsLambda (38.61s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/OpenIDConnect_issuer (28.26s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/LambdaAuthorizerConfig_authorizerUri (49.17s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/visibility (16.98s)
        --- PASS: TestAccAppSync_serial/GraphQLAPI/basic (17.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appsync	940.449s

@ewbankkit
Copy link
Contributor

@DrFaust92 @alekc Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit added this to the v5.1.0 milestone May 12, 2023
@itaywol
Copy link

itaywol commented May 29, 2023

@ewbankkit Hey 😄 can we get this merged please

@ewbankkit ewbankkit merged commit 7a31872 into hashicorp:main May 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

This functionality has been released in v5.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@itaywol itaywol mentioned this pull request Jun 3, 2023
Merged
3 tasks
@github-actions
Copy link

github-actions bot commented Jul 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.

Appsync schema error is not returning proper error description
4 participants
@DrFaust92 @ewbankkit @itaywol @alekc