feat!: Added appsync visibility option, bump AWS provider version to 5.x #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaywol
changed the title
itaywol
changed the title
|
@antonbabenko Kindly review this please 🙏🏻 |
antonbabenko
requested changes
Jun 5, 2023
variables.tf
Outdated
| variable "visibility" { | ||
| description = "The API visibility. Valid values: GLOBAL, PRIVATE." | ||
| type = string | ||
| default = "GLOBAL" |
There was a problem hiding this comment.
Suggested change
| default = "GLOBAL" | |
| default = null |
variables.tf
Outdated
| type = string | ||
| default = "GLOBAL" | ||
|
|
||
| validation { |
There was a problem hiding this comment.
Please remove this validation block completely.
antonbabenko
changed the title
antonbabenko
approved these changes
Jun 5, 2023
|
This PR is included in version 2.0.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AWS added a feature to AppSync to allow creating private APIs (link to the article).
Corresponding to that a PR hashicorp merged into release 5.1.0 of terraform-provider-aws.
In my PR i have added the visibility option to the appsync module.
Motivation and Context
It adds a missing feature.
Breaking Changes
None.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request