-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aws_ce_anomaly_subscription crash on update of monitor_arn_list #25941
Fix aws_ce_anomaly_subscription crash on update of monitor_arn_list #25941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @ahuseby 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCEAnomalySubscription_' PKG=ce ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 2 -run=TestAccCEAnomalySubscription_ -timeout 180m
=== RUN TestAccCEAnomalySubscription_basic
=== PAUSE TestAccCEAnomalySubscription_basic
=== RUN TestAccCEAnomalySubscription_disappears
=== PAUSE TestAccCEAnomalySubscription_disappears
=== RUN TestAccCEAnomalySubscription_Frequency
=== PAUSE TestAccCEAnomalySubscription_Frequency
=== RUN TestAccCEAnomalySubscription_MonitorARNList
=== PAUSE TestAccCEAnomalySubscription_MonitorARNList
=== RUN TestAccCEAnomalySubscription_Subscriber
=== PAUSE TestAccCEAnomalySubscription_Subscriber
=== RUN TestAccCEAnomalySubscription_Threshold
=== PAUSE TestAccCEAnomalySubscription_Threshold
=== RUN TestAccCEAnomalySubscription_Tags
=== PAUSE TestAccCEAnomalySubscription_Tags
=== CONT TestAccCEAnomalySubscription_basic
=== CONT TestAccCEAnomalySubscription_Subscriber
--- PASS: TestAccCEAnomalySubscription_basic (16.95s)
=== CONT TestAccCEAnomalySubscription_Frequency
--- PASS: TestAccCEAnomalySubscription_Frequency (27.36s)
=== CONT TestAccCEAnomalySubscription_MonitorARNList
--- PASS: TestAccCEAnomalySubscription_Subscriber (57.87s)
=== CONT TestAccCEAnomalySubscription_disappears
--- PASS: TestAccCEAnomalySubscription_disappears (12.68s)
=== CONT TestAccCEAnomalySubscription_Tags
--- PASS: TestAccCEAnomalySubscription_MonitorARNList (26.44s)
=== CONT TestAccCEAnomalySubscription_Threshold
--- PASS: TestAccCEAnomalySubscription_Threshold (27.57s)
--- PASS: TestAccCEAnomalySubscription_Tags (38.64s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ce 113.058s
@ahuseby Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #25930
Output from acceptance testing: