-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/s3_bucket_versioning: support disabled versioning i.e. unversioned buckets #23723
Conversation
2b12b90
to
4651686
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTS=TestAccS3BucketVersioning_ PKG=s3 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3/... -v -count 1 -parallel 3 -run='TestAccS3BucketVersioning_' -timeout 180m
=== RUN TestAccS3BucketVersioning_basic
=== PAUSE TestAccS3BucketVersioning_basic
=== RUN TestAccS3BucketVersioning_disappears
=== PAUSE TestAccS3BucketVersioning_disappears
=== RUN TestAccS3BucketVersioning_update
=== PAUSE TestAccS3BucketVersioning_update
=== RUN TestAccS3BucketVersioning_MFADelete
=== PAUSE TestAccS3BucketVersioning_MFADelete
=== RUN TestAccS3BucketVersioning_Status_disabled
=== PAUSE TestAccS3BucketVersioning_Status_disabled
=== RUN TestAccS3BucketVersioning_Status_disabledToEnabled
=== PAUSE TestAccS3BucketVersioning_Status_disabledToEnabled
=== RUN TestAccS3BucketVersioning_Status_disabledToSuspended
=== PAUSE TestAccS3BucketVersioning_Status_disabledToSuspended
=== RUN TestAccS3BucketVersioning_Status_enabledToDisabled
=== PAUSE TestAccS3BucketVersioning_Status_enabledToDisabled
=== RUN TestAccS3BucketVersioning_Status_suspendedToDisabled
=== PAUSE TestAccS3BucketVersioning_Status_suspendedToDisabled
=== CONT TestAccS3BucketVersioning_basic
=== CONT TestAccS3BucketVersioning_Status_disabledToEnabled
=== CONT TestAccS3BucketVersioning_MFADelete
--- PASS: TestAccS3BucketVersioning_MFADelete (28.23s)
=== CONT TestAccS3BucketVersioning_update
--- PASS: TestAccS3BucketVersioning_basic (28.38s)
=== CONT TestAccS3BucketVersioning_disappears
--- PASS: TestAccS3BucketVersioning_Status_disabledToEnabled (49.97s)
=== CONT TestAccS3BucketVersioning_Status_enabledToDisabled
--- PASS: TestAccS3BucketVersioning_disappears (23.42s)
=== CONT TestAccS3BucketVersioning_Status_suspendedToDisabled
--- PASS: TestAccS3BucketVersioning_Status_enabledToDisabled (28.37s)
=== CONT TestAccS3BucketVersioning_Status_disabled
--- PASS: TestAccS3BucketVersioning_Status_suspendedToDisabled (28.09s)
=== CONT TestAccS3BucketVersioning_Status_disabledToSuspended
--- PASS: TestAccS3BucketVersioning_update (69.79s)
--- PASS: TestAccS3BucketVersioning_Status_disabled (29.13s)
--- PASS: TestAccS3BucketVersioning_Status_disabledToSuspended (61.40s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 144.991s
r/s3_bucket_versioning: backport #23723; support management of resource with disabled versioning
This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #23718
Output from acceptance testing: