Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/resource/aws_eks_node_group: Launch Template Version and Release Version Failures #16146

Closed
bflad opened this issue Nov 11, 2020 · 2 comments · Fixed by #16164
Closed

tests/resource/aws_eks_node_group: Launch Template Version and Release Version Failures #16146

bflad opened this issue Nov 11, 2020 · 2 comments · Fixed by #16164
Assignees
@bflad
Labels
service/eks Issues and PRs that pertain to the eks service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone
v3.15.0

Comments

@bflad
Copy link
Contributor

bflad commented Nov 11, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The following two test failures are present on the main branch:

=== CONT  TestAccAWSEksNodeGroup_LaunchTemplate_Version
TestAccAWSEksNodeGroup_LaunchTemplate_Version: resource_aws_eks_node_group_test.go:394: Step 3/3, expected an error but got none
--- FAIL: TestAccAWSEksNodeGroup_LaunchTemplate_Version (2495.73s)

=== CONT  TestAccAWSEksNodeGroup_ReleaseVersion
TestAccAWSEksNodeGroup_ReleaseVersion: resource_aws_eks_node_group_test.go:433: Step 3/3 error: Error running apply: 2020/11/11 10:20:03 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error updating EKS Node Group (tf-acc-test-7656789780485850868:tf-acc-test-7656789780485850868) version: InvalidParameterException: Requested Nodegroup release version 1.16.13-20201007 is invalid. Allowed release version is 1.16.15-20201107
{
RespMetadata: {
StatusCode: 400,
RequestID: "17a52d81-285a-4e03-924c-874d3d895e3b"
},
ClusterName: "tf-acc-test-7656789780485850868",
Message_: "Requested Nodegroup release version 1.16.13-20201007 is invalid. Allowed release version is 1.16.15-20201107",
NodegroupName: "tf-acc-test-7656789780485850868"
}
--- FAIL: TestAccAWSEksNodeGroup_ReleaseVersion (4466.46s)

In the first case, it appears the service team has fixed the UpdateNodeGroup API issue. 🎉 In the second case, it appears SSM parameter and API are out of sync. Created an upstream issue.

Affected Resource(s)

  • aws_eks_node_group

References
@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. technical-debt Addresses areas of the codebase that need refactoring or redesign. service/eks Issues and PRs that pertain to the eks service. labels Nov 11, 2020
@bflad bflad self-assigned this Nov 11, 2020
bflad added a commit that referenced this issue Nov 12, 2020
@bflad
tests/resource/aws_eks_node_group: Fix test failures
6319566 
Reference: #16146
Reference: aws/containers-roadmap#771
Reference: awslabs/amazon-eks-ami#559

Previously:

```
=== CONT  TestAccAWSEksNodeGroup_LaunchTemplate_Version
TestAccAWSEksNodeGroup_LaunchTemplate_Version: resource_aws_eks_node_group_test.go:394: Step 3/3, expected an error but got none
--- FAIL: TestAccAWSEksNodeGroup_LaunchTemplate_Version (2495.73s)

=== CONT  TestAccAWSEksNodeGroup_ReleaseVersion
TestAccAWSEksNodeGroup_ReleaseVersion: resource_aws_eks_node_group_test.go:433: Step 3/3 error: Error running apply: 2020/11/11 10:20:03 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error updating EKS Node Group (tf-acc-test-7656789780485850868:tf-acc-test-7656789780485850868) version: InvalidParameterException: Requested Nodegroup release version 1.16.13-20201007 is invalid. Allowed release version is 1.16.15-20201107
{
RespMetadata: {
StatusCode: 400,
RequestID: "17a52d81-285a-4e03-924c-874d3d895e3b"
},
ClusterName: "tf-acc-test-7656789780485850868",
Message_: "Requested Nodegroup release version 1.16.13-20201007 is invalid. Allowed release version is 1.16.15-20201107",
NodegroupName: "tf-acc-test-7656789780485850868"
}
--- FAIL: TestAccAWSEksNodeGroup_ReleaseVersion (4466.46s)
```

Output from acceptance testing:

```
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Version (2424.12s)
--- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (4059.77s)
```
@bflad bflad mentioned this issue Nov 12, 2020
Merged
bflad added a commit that referenced this issue Nov 12, 2020
@bflad
tests/resource/aws_eks_node_group: Fix test failures (#16164)
63df631 
Reference: #16146
Reference: aws/containers-roadmap#771
Reference: awslabs/amazon-eks-ami#559

Previously:

```
=== CONT  TestAccAWSEksNodeGroup_LaunchTemplate_Version
TestAccAWSEksNodeGroup_LaunchTemplate_Version: resource_aws_eks_node_group_test.go:394: Step 3/3, expected an error but got none
--- FAIL: TestAccAWSEksNodeGroup_LaunchTemplate_Version (2495.73s)

=== CONT  TestAccAWSEksNodeGroup_ReleaseVersion
TestAccAWSEksNodeGroup_ReleaseVersion: resource_aws_eks_node_group_test.go:433: Step 3/3 error: Error running apply: 2020/11/11 10:20:03 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error updating EKS Node Group (tf-acc-test-7656789780485850868:tf-acc-test-7656789780485850868) version: InvalidParameterException: Requested Nodegroup release version 1.16.13-20201007 is invalid. Allowed release version is 1.16.15-20201107
{
RespMetadata: {
StatusCode: 400,
RequestID: "17a52d81-285a-4e03-924c-874d3d895e3b"
},
ClusterName: "tf-acc-test-7656789780485850868",
Message_: "Requested Nodegroup release version 1.16.13-20201007 is invalid. Allowed release version is 1.16.15-20201107",
NodegroupName: "tf-acc-test-7656789780485850868"
}
--- FAIL: TestAccAWSEksNodeGroup_ReleaseVersion (4466.46s)
```

Output from acceptance testing:

```
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Version (2424.12s)
--- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (4059.77s)
```
@bflad bflad added this to the v3.15.0 milestone Nov 12, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

bflad added a commit that referenced this issue Dec 1, 2020
@bflad
resource/aws_eks_node_group: Add capacity_type argument and support m…
904adeb 
…ultiple instance_types

Output from acceptance testing (see #16146 for unrelated failure triage on the main branch):

```
--- FAIL: TestAccAWSEksNodeGroup_LaunchTemplate_Version (2588.15s)
--- FAIL: TestAccAWSEksNodeGroup_ReleaseVersion (4116.90s)
--- PASS: TestAccAWSEksNodeGroup_AmiType (1739.66s)
--- PASS: TestAccAWSEksNodeGroup_basic (1263.54s)
--- PASS: TestAccAWSEksNodeGroup_CapacityType_Spot (1397.33s)
--- PASS: TestAccAWSEksNodeGroup_disappears (1359.08s)
--- PASS: TestAccAWSEksNodeGroup_DiskSize (1284.23s)
--- PASS: TestAccAWSEksNodeGroup_ForceUpdateVersion (5320.15s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes_Multiple (1232.97s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes_Single (1490.11s)
--- PASS: TestAccAWSEksNodeGroup_Labels (1268.53s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Id (1711.11s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Name (1661.18s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1292.95s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1306.54s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1189.50s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1358.88s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1428.47s)
--- PASS: TestAccAWSEksNodeGroup_Tags (1366.22s)
--- PASS: TestAccAWSEksNodeGroup_Version (5252.66s)
```
bflad added a commit that referenced this issue Dec 1, 2020
@bflad
resource/aws_eks_node_group: Add capacity_type argument and support m…
7cc0810 
…ultiple instance_types (#16510)

Output from acceptance testing (see #16146 for unrelated failure triage on the main branch):

```
--- FAIL: TestAccAWSEksNodeGroup_LaunchTemplate_Version (2588.15s)
--- FAIL: TestAccAWSEksNodeGroup_ReleaseVersion (4116.90s)
--- PASS: TestAccAWSEksNodeGroup_AmiType (1739.66s)
--- PASS: TestAccAWSEksNodeGroup_basic (1263.54s)
--- PASS: TestAccAWSEksNodeGroup_CapacityType_Spot (1397.33s)
--- PASS: TestAccAWSEksNodeGroup_disappears (1359.08s)
--- PASS: TestAccAWSEksNodeGroup_DiskSize (1284.23s)
--- PASS: TestAccAWSEksNodeGroup_ForceUpdateVersion (5320.15s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes_Multiple (1232.97s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes_Single (1490.11s)
--- PASS: TestAccAWSEksNodeGroup_Labels (1268.53s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Id (1711.11s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Name (1661.18s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1292.95s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1306.54s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1189.50s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1358.88s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1428.47s)
--- PASS: TestAccAWSEksNodeGroup_Tags (1366.22s)
--- PASS: TestAccAWSEksNodeGroup_Version (5252.66s)
```
@ghost
Copy link

ghost commented Dec 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
service/eks Issues and PRs that pertain to the eks service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.15.0
Development

Successfully merging a pull request may close this issue.

tests/resource/aws_eks_node_group: Fix test failures hashicorp/terraform-provider-aws
1 participant
@bflad