provider: Switch Resources To Terraform Plugin SDK V2 WithoutTimeout Signatures #15090

bflad · 2020-09-09T14:37:55Z

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Placeholder Note: This issue is to start design and tracking work for this SDK v2 upgrade process. Once design decisions are complete, it is likely that the migration process will be automated in some fashion.

We recently went through a massive effort to migrate all resources to Terraform Plugin SDK version 2. This now will allow us to begin utilizing newer SDK features in resources, such as working with the shared Terraform core context and implementing user interface warnings instead of just logs.

Version 1 resources implement helper/schema.Resource fields Create, Read, Update, and Delete, while version 2 resources implement CreateContext, ReadContext, UpdateContext, and DeleteContext. The updated function signatures include a new context.Context parameter and use a diag.Diagnostics return value. The simplest conversion process would to always just return diagnostic errors (e.g. using diag.FromErr()), however some resources it may be desirable to also return warning diagnostics from prior logic.

Affected Resource(s)

All existing data sources and resources 😄

References

The text was updated successfully, but these errors were encountered:

ewbankkit · 2020-09-14T18:08:53Z

Some high-level remarks/questions:

After swapping to the Context version of the Resource methods, should the resource's code be changed to use the WithContext version of AWS SDK methods (e.g. RunInstancesWithContext)?
How does the timeout passed to functions like resource.Retry(Context) or resource.StateChangeConf.WaitForState(Context) interact with the deadline set on the context object passed to the Context version of the Resource methods?

bflad · 2020-09-14T18:48:23Z

After swapping to the Context version of the Resource methods, should the resource's code be changed to use the WithContext version of AWS SDK methods (e.g. RunInstancesWithContext)?

Eventually since that is what will help solve #4177, but probably should be tracked separately from this issue. It might become part of a AWS Go SDK version 2 migration, depending on timing or if the maintainers want to deal with differing code/behaviors across the codebase to try to implement the "new way" for new contributions.

How does the timeout passed to functions like resource.Retry(Context) or resource.StateChangeConf.WaitForState(Context) interact with the deadline set on the context object passed to the Context version of the Resource methods?

I believe whichever timeout/deadline expires first will just take precedence on cancelling the retry looping:

https://github.com/hashicorp/terraform-plugin-sdk/blob/a8e5eaf628dcbd66869b9512e81c3495cfac5722/helper/resource/state.go#L223-L236

Similar to the above though, it should likely a separate followup task from this one since its not required for this task.

nfx · 2020-09-15T16:19:40Z

subscribing to comments in case there'll be a way to semi-automatically convert everything

bflad · 2021-03-25T10:06:56Z

Terraform Plugin SDK v2.5.0 includes CreateWithoutTimeout, DeleteWithoutTimeout, ReadWithoutTimeout, and UpdateWithoutTimeout fields on helper/schema.Resource, which skips setting the context timeout. This effectively unblocks this effort by resolving two issues for this conversion: hashicorp/terraform-plugin-sdk#675
and where resource logic includes hardcoded timeout logic (not set in the schema) over the default 20 minutes of the SDK context timeout.

We should now be able to perform function signature migration without risking regressions.

There is one minor item to cover, which is ensuring testAccCheckResourceDisappears has support for DeleteWithoutTimeout. I will submit this now.

… in testAccCheckResourceDisappears Reference: #15090 Output from acceptance testing: ``` # Existing Delete --- PASS: TestAccAWSXrayGroup_disappears (15.90s) # Existing DeleteContext --- PASS: TestAccAWSAMPWorkspace_disappears (13.63s) ```

… in testAccCheckResourceDisappears (#18398) Reference: #15090 Output from acceptance testing: ``` # Existing Delete --- PASS: TestAccAWSXrayGroup_disappears (15.90s) # Existing DeleteContext --- PASS: TestAccAWSAMPWorkspace_disappears (13.63s) ```

ewbankkit · 2021-04-26T14:31:50Z

Any thoughts around use of WithTimeout for the data source Read function?

bflad · 2021-04-27T20:12:11Z

Same can be applied to data sources as well. Sorry "resources" was meant to be generically both rather than just managed resource types.

…dler signatures (hashicorp#15090). Acceptance test output: % AWS_DEFAULT_REGION=us-east-1 ROUTE53DOMAINS_DOMAIN_NAME=terraform-provider-aws-acctest-acm.com make testacc TESTS=TestAccRoute53Domains_serial/RegisteredDomain/tags PKG=route53domains ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/route53domains/... -v -count 1 -parallel 20 -run='TestAccRoute53Domains_serial/RegisteredDomain/tags' -timeout 180m === RUN TestAccRoute53Domains_serial === RUN TestAccRoute53Domains_serial/RegisteredDomain === RUN TestAccRoute53Domains_serial/RegisteredDomain/tags --- PASS: TestAccRoute53Domains_serial (24.76s) --- PASS: TestAccRoute53Domains_serial/RegisteredDomain (24.76s) --- PASS: TestAccRoute53Domains_serial/RegisteredDomain/tags (24.76s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/route53domains 28.274s

…signatures (hashicorp#15090).

…meout' signatures (#15090).

…K V2 'WithoutTimeout' signatures (#15090).

…gnatures (hashicorp#15090).

). Acceptance test output: % make testacc TESTARGS='-run=TestAccMQConfiguration_' PKG=mq ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/mq/... -v -count 1 -parallel 2 -run=TestAccMQConfiguration_ -timeout 180m === RUN TestAccMQConfiguration_basic === PAUSE TestAccMQConfiguration_basic === RUN TestAccMQConfiguration_withData === PAUSE TestAccMQConfiguration_withData === RUN TestAccMQConfiguration_withLdapData === PAUSE TestAccMQConfiguration_withLdapData === RUN TestAccMQConfiguration_tags === PAUSE TestAccMQConfiguration_tags === CONT TestAccMQConfiguration_basic === CONT TestAccMQConfiguration_withLdapData --- PASS: TestAccMQConfiguration_withLdapData (25.43s) === CONT TestAccMQConfiguration_withData --- PASS: TestAccMQConfiguration_basic (35.47s) === CONT TestAccMQConfiguration_tags --- PASS: TestAccMQConfiguration_withData (20.19s) --- PASS: TestAccMQConfiguration_tags (47.72s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/mq 88.212s

…RUD handlers (#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccMQBrokerInstanceTypeOfferingsDataSource_' PKG=mq ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/mq/... -v -count 1 -parallel 2 -run=TestAccMQBrokerInstanceTypeOfferingsDataSource_ -timeout 180m === RUN TestAccMQBrokerInstanceTypeOfferingsDataSource_basic === PAUSE TestAccMQBrokerInstanceTypeOfferingsDataSource_basic === CONT TestAccMQBrokerInstanceTypeOfferingsDataSource_basic --- PASS: TestAccMQBrokerInstanceTypeOfferingsDataSource_basic (18.12s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/mq 22.768s

…). Acceptance test output: % make testacc TESTARGS='-run=TestAccEFSFileSystem_' PKG=efs ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 2 -run=TestAccEFSFileSystem_ -timeout 180m === RUN TestAccEFSFileSystem_basic === PAUSE TestAccEFSFileSystem_basic === RUN TestAccEFSFileSystem_disappears === PAUSE TestAccEFSFileSystem_disappears === RUN TestAccEFSFileSystem_performanceMode === PAUSE TestAccEFSFileSystem_performanceMode === RUN TestAccEFSFileSystem_availabilityZoneName === PAUSE TestAccEFSFileSystem_availabilityZoneName === RUN TestAccEFSFileSystem_tags === PAUSE TestAccEFSFileSystem_tags === RUN TestAccEFSFileSystem_kmsKey === PAUSE TestAccEFSFileSystem_kmsKey === RUN TestAccEFSFileSystem_kmsWithoutEncryption === PAUSE TestAccEFSFileSystem_kmsWithoutEncryption === RUN TestAccEFSFileSystem_provisionedThroughputInMibps === PAUSE TestAccEFSFileSystem_provisionedThroughputInMibps === RUN TestAccEFSFileSystem_throughputMode === PAUSE TestAccEFSFileSystem_throughputMode === RUN TestAccEFSFileSystem_lifecyclePolicy === PAUSE TestAccEFSFileSystem_lifecyclePolicy === CONT TestAccEFSFileSystem_basic === CONT TestAccEFSFileSystem_kmsKey --- PASS: TestAccEFSFileSystem_basic (29.08s) === CONT TestAccEFSFileSystem_throughputMode --- PASS: TestAccEFSFileSystem_kmsKey (30.19s) === CONT TestAccEFSFileSystem_lifecyclePolicy --- PASS: TestAccEFSFileSystem_throughputMode (46.36s) === CONT TestAccEFSFileSystem_provisionedThroughputInMibps --- PASS: TestAccEFSFileSystem_lifecyclePolicy (73.86s) === CONT TestAccEFSFileSystem_kmsWithoutEncryption --- PASS: TestAccEFSFileSystem_kmsWithoutEncryption (10.34s) === CONT TestAccEFSFileSystem_availabilityZoneName --- PASS: TestAccEFSFileSystem_provisionedThroughputInMibps (46.52s) === CONT TestAccEFSFileSystem_tags --- PASS: TestAccEFSFileSystem_availabilityZoneName (30.14s) === CONT TestAccEFSFileSystem_performanceMode --- PASS: TestAccEFSFileSystem_performanceMode (23.37s) === CONT TestAccEFSFileSystem_disappears --- PASS: TestAccEFSFileSystem_disappears (21.22s) --- PASS: TestAccEFSFileSystem_tags (81.64s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/efs 208.223s

…icorp#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccRUMAppMonitor_' PKG=rum ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/rum/... -v -count 1 -parallel 3 -run=TestAccRUMAppMonitor_ -timeout 180m === RUN TestAccRUMAppMonitor_basic === PAUSE TestAccRUMAppMonitor_basic === RUN TestAccRUMAppMonitor_tags === PAUSE TestAccRUMAppMonitor_tags === RUN TestAccRUMAppMonitor_disappears === PAUSE TestAccRUMAppMonitor_disappears === CONT TestAccRUMAppMonitor_basic === CONT TestAccRUMAppMonitor_disappears === CONT TestAccRUMAppMonitor_tags --- PASS: TestAccRUMAppMonitor_disappears (15.75s) --- PASS: TestAccRUMAppMonitor_basic (31.95s) --- PASS: TestAccRUMAppMonitor_tags (41.23s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/rum 46.586s

…rs (hashicorp#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccRUMMetricsDestination_' PKG=rum ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/rum/... -v -count 1 -parallel 3 -run=TestAccRUMMetricsDestination_ -timeout 180m === RUN TestAccRUMMetricsDestination_basic === PAUSE TestAccRUMMetricsDestination_basic === RUN TestAccRUMMetricsDestination_disappears === PAUSE TestAccRUMMetricsDestination_disappears === RUN TestAccRUMMetricsDestination_disappears_appMonitor === PAUSE TestAccRUMMetricsDestination_disappears_appMonitor === CONT TestAccRUMMetricsDestination_basic === CONT TestAccRUMMetricsDestination_disappears_appMonitor === CONT TestAccRUMMetricsDestination_disappears --- PASS: TestAccRUMMetricsDestination_disappears_appMonitor (16.24s) --- PASS: TestAccRUMMetricsDestination_disappears (18.22s) --- PASS: TestAccRUMMetricsDestination_basic (20.54s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/rum 25.636s

…'WithoutTimeout' CRUD handlers (#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccS3ControlAccessPoint' PKG=s3control ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3 -run=TestAccS3ControlAccessPoint -timeout 180m === RUN TestAccS3ControlAccessPointPolicy_basic === PAUSE TestAccS3ControlAccessPointPolicy_basic === RUN TestAccS3ControlAccessPointPolicy_disappears === PAUSE TestAccS3ControlAccessPointPolicy_disappears === RUN TestAccS3ControlAccessPointPolicy_disappears_AccessPoint === PAUSE TestAccS3ControlAccessPointPolicy_disappears_AccessPoint === RUN TestAccS3ControlAccessPointPolicy_update === PAUSE TestAccS3ControlAccessPointPolicy_update === RUN TestAccS3ControlAccessPoint_basic === PAUSE TestAccS3ControlAccessPoint_basic === RUN TestAccS3ControlAccessPoint_disappears === PAUSE TestAccS3ControlAccessPoint_disappears === RUN TestAccS3ControlAccessPoint_Bucket_arn === PAUSE TestAccS3ControlAccessPoint_Bucket_arn === RUN TestAccS3ControlAccessPoint_policy === PAUSE TestAccS3ControlAccessPoint_policy === RUN TestAccS3ControlAccessPoint_publicAccessBlock === PAUSE TestAccS3ControlAccessPoint_publicAccessBlock === RUN TestAccS3ControlAccessPoint_vpc === PAUSE TestAccS3ControlAccessPoint_vpc === CONT TestAccS3ControlAccessPointPolicy_basic === CONT TestAccS3ControlAccessPoint_disappears === CONT TestAccS3ControlAccessPointPolicy_update --- PASS: TestAccS3ControlAccessPoint_disappears (22.69s) === CONT TestAccS3ControlAccessPoint_basic --- PASS: TestAccS3ControlAccessPointPolicy_basic (25.78s) === CONT TestAccS3ControlAccessPoint_publicAccessBlock --- PASS: TestAccS3ControlAccessPointPolicy_update (41.65s) === CONT TestAccS3ControlAccessPoint_vpc --- PASS: TestAccS3ControlAccessPoint_basic (21.08s) === CONT TestAccS3ControlAccessPointPolicy_disappears_AccessPoint --- PASS: TestAccS3ControlAccessPoint_publicAccessBlock (20.66s) === CONT TestAccS3ControlAccessPoint_policy --- PASS: TestAccS3ControlAccessPointPolicy_disappears_AccessPoint (18.59s) === CONT TestAccS3ControlAccessPointPolicy_disappears --- PASS: TestAccS3ControlAccessPoint_vpc (22.30s) === CONT TestAccS3ControlAccessPoint_Bucket_arn acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlAccessPoint_Bucket_arn (0.76s) --- PASS: TestAccS3ControlAccessPointPolicy_disappears (19.75s) --- PASS: TestAccS3ControlAccessPoint_policy (51.57s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3control 103.083s

…_block: Switch to 'WithoutTimeout' CRUD handlers (#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccS3ControlAccountPublicAccessBlock_serial' PKG=s3control ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3 -run=TestAccS3ControlAccountPublicAccessBlock_serial -timeout 180m === RUN TestAccS3ControlAccountPublicAccessBlock_serial === RUN TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock === RUN TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/IgnorePublicAcls === RUN TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/RestrictPublicBuckets === RUN TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/DataSourceBasic === RUN TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/basic === RUN TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/disappears === RUN TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/AccountId === RUN TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicAcls === RUN TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicPolicy --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial (281.95s) --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock (281.95s) --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/IgnorePublicAcls (53.59s) --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/RestrictPublicBuckets (51.64s) --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/DataSourceBasic (17.86s) --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/basic (20.37s) --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/disappears (16.18s) --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/AccountId (20.41s) --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicAcls (51.20s) --- PASS: TestAccS3ControlAccountPublicAccessBlock_serial/PublicAccessBlock/BlockPublicPolicy (50.69s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3control 286.966s

…eout' CRUD handlers (#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccS3ControlBucketLifecycleConfiguration_' PKG=s3control ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3 -run=TestAccS3ControlBucketLifecycleConfiguration_ -timeout 180m === RUN TestAccS3ControlBucketLifecycleConfiguration_basic === PAUSE TestAccS3ControlBucketLifecycleConfiguration_basic === RUN TestAccS3ControlBucketLifecycleConfiguration_disappears === PAUSE TestAccS3ControlBucketLifecycleConfiguration_disappears === RUN TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation === PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation === RUN TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date === PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date === RUN TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days === PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days === RUN TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_expiredObjectDeleteMarker acctest.go:71: S3 on Outposts does not error or save it in the API when receiving this parameter --- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_expiredObjectDeleteMarker (0.00s) === RUN TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix === PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix === RUN TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags === PAUSE TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags === RUN TestAccS3ControlBucketLifecycleConfiguration_Rule_id === PAUSE TestAccS3ControlBucketLifecycleConfiguration_Rule_id === RUN TestAccS3ControlBucketLifecycleConfiguration_Rule_status === PAUSE TestAccS3ControlBucketLifecycleConfiguration_Rule_status === CONT TestAccS3ControlBucketLifecycleConfiguration_basic === CONT TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix === CONT TestAccS3ControlBucketLifecycleConfiguration_Rule_id === CONT TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_prefix (4.26s) === CONT TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags === CONT TestAccS3ControlBucketLifecycleConfiguration_basic acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucketLifecycleConfiguration_basic (4.32s) === CONT TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date === CONT TestAccS3ControlBucketLifecycleConfiguration_Rule_id acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucketLifecycleConfiguration_Rule_id (4.38s) === CONT TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days === CONT TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleFilter_tags (0.20s) === CONT TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation === CONT TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_date (0.18s) === CONT TestAccS3ControlBucketLifecycleConfiguration_disappears === CONT TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleExpiration_days (0.24s) === CONT TestAccS3ControlBucketLifecycleConfiguration_Rule_status === CONT TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucketLifecycleConfiguration_RuleAbortIncompleteMultipartUpload_daysAfterInitiation (0.19s) === CONT TestAccS3ControlBucketLifecycleConfiguration_disappears acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucketLifecycleConfiguration_disappears (0.17s) === CONT TestAccS3ControlBucketLifecycleConfiguration_Rule_status acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucketLifecycleConfiguration_Rule_status (1.39s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3control 12.331s

). Acceptance test output: % make testacc TESTARGS='-run=TestAccS3ControlBucket_' PKG=s3control ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3 -run=TestAccS3ControlBucket_ -timeout 180m === RUN TestAccS3ControlBucket_basic === PAUSE TestAccS3ControlBucket_basic === RUN TestAccS3ControlBucket_disappears === PAUSE TestAccS3ControlBucket_disappears === RUN TestAccS3ControlBucket_tags acctest.go:71: S3 Control Bucket resource tagging requires additional eventual consistency handling, see also: #15572 --- SKIP: TestAccS3ControlBucket_tags (0.00s) === CONT TestAccS3ControlBucket_basic === CONT TestAccS3ControlBucket_disappears acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucket_disappears (1.00s) === CONT TestAccS3ControlBucket_basic acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucket_basic (1.07s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3control 6.289s

…rs (#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccS3ControlBucketPolicy_' PKG=s3control ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3 -run=TestAccS3ControlBucketPolicy_ -timeout 180m === RUN TestAccS3ControlBucketPolicy_basic === PAUSE TestAccS3ControlBucketPolicy_basic === RUN TestAccS3ControlBucketPolicy_disappears === PAUSE TestAccS3ControlBucketPolicy_disappears === RUN TestAccS3ControlBucketPolicy_policy === PAUSE TestAccS3ControlBucketPolicy_policy === CONT TestAccS3ControlBucketPolicy_basic === CONT TestAccS3ControlBucketPolicy_policy === CONT TestAccS3ControlBucketPolicy_disappears === CONT TestAccS3ControlBucketPolicy_basic acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucketPolicy_basic (0.92s) === CONT TestAccS3ControlBucketPolicy_policy acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucketPolicy_policy (0.94s) === CONT TestAccS3ControlBucketPolicy_disappears acctest.go:1368: skipping since no Outposts found --- SKIP: TestAccS3ControlBucketPolicy_disappears (0.98s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3control 6.277s

…ion_access_point_policy: Switch to 'WithoutTimeout' CRUD handlers (#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccS3ControlMultiRegionAccessPoint' PKG=s3control ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3 -run=TestAccS3ControlMultiRegionAccessPoint -timeout 180m === RUN TestAccS3ControlMultiRegionAccessPointDataSource_basic === PAUSE TestAccS3ControlMultiRegionAccessPointDataSource_basic === RUN TestAccS3ControlMultiRegionAccessPointPolicy_basic === PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_basic === RUN TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint === PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint === RUN TestAccS3ControlMultiRegionAccessPointPolicy_details_policy === PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_details_policy === RUN TestAccS3ControlMultiRegionAccessPointPolicy_details_name === PAUSE TestAccS3ControlMultiRegionAccessPointPolicy_details_name === RUN TestAccS3ControlMultiRegionAccessPoint_basic === PAUSE TestAccS3ControlMultiRegionAccessPoint_basic === RUN TestAccS3ControlMultiRegionAccessPoint_disappears === PAUSE TestAccS3ControlMultiRegionAccessPoint_disappears === RUN TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock === PAUSE TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock === RUN TestAccS3ControlMultiRegionAccessPoint_name === PAUSE TestAccS3ControlMultiRegionAccessPoint_name === RUN TestAccS3ControlMultiRegionAccessPoint_threeRegions === PAUSE TestAccS3ControlMultiRegionAccessPoint_threeRegions === CONT TestAccS3ControlMultiRegionAccessPointDataSource_basic === CONT TestAccS3ControlMultiRegionAccessPoint_basic === CONT TestAccS3ControlMultiRegionAccessPoint_threeRegions --- PASS: TestAccS3ControlMultiRegionAccessPoint_basic (336.67s) === CONT TestAccS3ControlMultiRegionAccessPoint_name --- PASS: TestAccS3ControlMultiRegionAccessPoint_threeRegions (348.44s) === CONT TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock --- PASS: TestAccS3ControlMultiRegionAccessPointDataSource_basic (359.54s) === CONT TestAccS3ControlMultiRegionAccessPoint_disappears --- PASS: TestAccS3ControlMultiRegionAccessPoint_disappears (256.99s) === CONT TestAccS3ControlMultiRegionAccessPointPolicy_details_policy --- PASS: TestAccS3ControlMultiRegionAccessPoint_PublicAccessBlock (333.59s) === CONT TestAccS3ControlMultiRegionAccessPointPolicy_details_name --- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_details_policy (265.17s) === CONT TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint --- PASS: TestAccS3ControlMultiRegionAccessPoint_name (587.22s) === CONT TestAccS3ControlMultiRegionAccessPointPolicy_basic --- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_disappears_MultiRegionAccessPoint (262.98s) --- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_details_name (526.15s) --- PASS: TestAccS3ControlMultiRegionAccessPointPolicy_basic (286.04s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3control 1215.420s

…' CRUD handlers (#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccS3ControlObjectLambdaAccessPoint_' PKG=s3control ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3 -run=TestAccS3ControlObjectLambdaAccessPoint_ -timeout 180m === RUN TestAccS3ControlObjectLambdaAccessPoint_basic === PAUSE TestAccS3ControlObjectLambdaAccessPoint_basic === RUN TestAccS3ControlObjectLambdaAccessPoint_disappears === PAUSE TestAccS3ControlObjectLambdaAccessPoint_disappears === RUN TestAccS3ControlObjectLambdaAccessPoint_update === PAUSE TestAccS3ControlObjectLambdaAccessPoint_update === CONT TestAccS3ControlObjectLambdaAccessPoint_basic === CONT TestAccS3ControlObjectLambdaAccessPoint_update === CONT TestAccS3ControlObjectLambdaAccessPoint_disappears --- PASS: TestAccS3ControlObjectLambdaAccessPoint_basic (45.60s) --- PASS: TestAccS3ControlObjectLambdaAccessPoint_disappears (48.86s) --- PASS: TestAccS3ControlObjectLambdaAccessPoint_update (73.36s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3control 78.453s

…Timeout' CRUD handlers (#15090). Acceptance test output: % make testacc TESTARGS='-run=TestAccS3ControlObjectLambdaAccessPointPolicy_' PKG=s3control ACCTEST_PARALLELISM=3 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 3 -run=TestAccS3ControlObjectLambdaAccessPointPolicy_ -timeout 180m === RUN TestAccS3ControlObjectLambdaAccessPointPolicy_basic === PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_basic === RUN TestAccS3ControlObjectLambdaAccessPointPolicy_disappears === PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_disappears === RUN TestAccS3ControlObjectLambdaAccessPointPolicy_Disappears_accessPoint === PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_Disappears_accessPoint === RUN TestAccS3ControlObjectLambdaAccessPointPolicy_update === PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_update === CONT TestAccS3ControlObjectLambdaAccessPointPolicy_basic === CONT TestAccS3ControlObjectLambdaAccessPointPolicy_update === CONT TestAccS3ControlObjectLambdaAccessPointPolicy_Disappears_accessPoint --- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_basic (52.85s) === CONT TestAccS3ControlObjectLambdaAccessPointPolicy_disappears --- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_Disappears_accessPoint (55.72s) --- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_update (63.83s) --- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_disappears (42.69s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/s3control 100.602s

gdavison · 2023-02-06T18:36:11Z

Closed by #29005

github-actions · 2023-03-09T02:18:55Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

bflad added technical-debt Addresses areas of the codebase that need refactoring or redesign. provider Pertains to the provider itself, rather than any interaction with AWS. labels Sep 9, 2020

bflad mentioned this issue Sep 9, 2020

Destroy is ignoring region from state file #15052

Closed

ewbankkit mentioned this issue Sep 12, 2020

Use aws-sdk-go-base/tfawserr in internal packages #13036

Merged

bflad mentioned this issue Sep 14, 2020

Integrate Provider Context For Cancelling Requests #4177

Closed

ewbankkit mentioned this issue Sep 25, 2020

New resource: aws_securityhub_standards_control #14714

Merged

bflad mentioned this issue Oct 2, 2020

tests/provider: Support (helper/schema.Resource).DeleteContext in testAccCheckResourceDisappears #15448

Merged

anGie44 mentioned this issue Nov 20, 2020

Tech debt: update networkfirewall resources to resource.RetryContext #16348

Closed

bflad mentioned this issue Jan 14, 2021

Consistent Error Handling for Setting Terraform State #17117

Closed

bflad mentioned this issue Jan 27, 2021

Error Messaging Updates for Diagnostics #17314

Closed

ewbankkit mentioned this issue Mar 11, 2021

Terraform state leaks on interrupt #18051

Closed

bflad changed the title ~~[PLACEHOLDER] Switch Resources To Terraform Plugin SDK V2 Signatures~~ provider: Switch Resources To Terraform Plugin SDK V2 WithoutTimeout Signatures Mar 25, 2021

bflad mentioned this issue Mar 25, 2021

tests/provider: Support (helper/schema.Resource).DeleteWithoutTimeout in testAccCheckResourceDisappears #18398

Merged

YakDriver self-assigned this Apr 8, 2021

This was referenced Aug 13, 2021

r/aws_eks_identity_provider_config: Acceptance tests fail with creation timeout #20558

Closed

r/aws_eks_identity_provider_config: Use CreateWithoutTimeoutet al. #20561

Merged

ewbankkit added a commit to bschaatsbergen/terraform-provider-aws that referenced this issue Feb 15, 2022

r/aws_cloudtrail_event_data_store: Use 'WithoutTimeout' CRUD handler …

9638789

…signatures (hashicorp#15090).

ewbankkit added a commit to abebars/terraform-provider-aws that referenced this issue Feb 17, 2022

d/aws_iam_openid_connect_provider: Embrace Context (hashicorp#15090).

f97a83f

ewbankkit added a commit that referenced this issue Feb 28, 2022

r/aws_ec2_transit_gateway_connect: Terraform Plugin SDK V2 'WithoutTi…

8e3b0b2

…meout' signatures (#15090).

ewbankkit added a commit that referenced this issue Mar 1, 2022

r/aws_ec2_transit_gateway_connect_peer: Switch to Terraform Plugin SD…

cd127ed

…K V2 'WithoutTimeout' signatures (#15090).

ewbankkit added a commit to george-richardson/terraform-provider-aws that referenced this issue Mar 2, 2022

r/aws_ec2_network_insights_path: Use 'WithoutTimeout' CRUD handler si…

4ffdafa

…gnatures (hashicorp#15090).

ewbankkit added a commit that referenced this issue Nov 22, 2022

r/aws_nat_gateway: Switch to 'WithoutTimeout' CRUD handlers (#15090).

4281e0f

ewbankkit added a commit that referenced this issue Nov 23, 2022

r/aws_mq_broker: Switch to 'WithoutTimeout' CRUD handlers (#15090).

bd1211c

ewbankkit reopened this Nov 23, 2022

ewbankkit mentioned this issue Nov 23, 2022

Tech debt: Switch to WithoutTimeout CRUD handlers for MQ #27989

Merged

gdavison removed this from the v4.41.0 milestone Nov 25, 2022

ewbankkit mentioned this issue Nov 28, 2022

Tech debt: Switch to WithoutTimeout CRUD handlers for aws_efs_file_system #28054

Merged

ewbankkit mentioned this issue Dec 16, 2022

Prefer WithoutTimeout variants over Context variants of resource CRUD handlers #28427

Closed

ewbankkit mentioned this issue Dec 23, 2022

Avoid direct calls to Resource.Delete in sweepers and acceptance tests #28556

Closed

ewbankkit mentioned this issue Dec 23, 2022

S3 Control: Access Point cross-account access & Storage Lens advanced metrics #28564

Merged

gdavison assigned gdavison and unassigned YakDriver Jan 9, 2023

gdavison mentioned this issue Jan 9, 2023

provider: Add scrubbing for sensitive data in logs #26029

Closed

ewbankkit mentioned this issue Jan 13, 2023

Proposal: Enable HTTP Response Recording for long running Acceptance Tests #25602

Open

3 tasks

gdavison closed this as completed Feb 6, 2023

github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provider: Switch Resources To Terraform Plugin SDK V2 WithoutTimeout Signatures #15090

provider: Switch Resources To Terraform Plugin SDK V2 WithoutTimeout Signatures #15090

bflad commented Sep 9, 2020

ewbankkit commented Sep 14, 2020

bflad commented Sep 14, 2020

nfx commented Sep 15, 2020

bflad commented Mar 25, 2021

ewbankkit commented Apr 26, 2021

bflad commented Apr 27, 2021

gdavison commented Feb 6, 2023

github-actions bot commented Mar 9, 2023

provider: Switch Resources To Terraform Plugin SDK V2 WithoutTimeout Signatures #15090

provider: Switch Resources To Terraform Plugin SDK V2 WithoutTimeout Signatures #15090

Comments

bflad commented Sep 9, 2020

Community Note

Description

Affected Resource(s)

References

ewbankkit commented Sep 14, 2020

bflad commented Sep 14, 2020

nfx commented Sep 15, 2020

bflad commented Mar 25, 2021

ewbankkit commented Apr 26, 2021

bflad commented Apr 27, 2021

gdavison commented Feb 6, 2023

github-actions bot commented Mar 9, 2023