Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMR create a new resource aws_emr_instances_fleet #1146

Closed
dthauvin opened this issue Jul 13, 2017 · 13 comments
Closed

EMR create a new resource aws_emr_instances_fleet #1146

dthauvin opened this issue Jul 13, 2017 · 13 comments
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/emr Issues and PRs that pertain to the emr service.
Milestone

Comments

@dthauvin
Copy link

Hi there,

Is it possible to create new resource which supports "instance fleets" for aws EMR ? with all features like :
-- Maximum bid price spot instance for master
--Maximum bid price for core et task type
-- On-demand vCPUs and Spot vCPUs for Core and task type
-- Defined duration and Provisioning timeout for core and task type

Terraform Version

Terraform v0.9.11

Affected Resource(s)

  • aws_emr_cluster
  • aws_emr_instance_group
@stack72 stack72 added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 14, 2017
@dthauvin
Copy link
Author

Hello
in the "AWS SDK for Go API Reference" we can find the AddInstanceFleet function .
If it helps .
http://docs.aws.amazon.com/sdk-for-go/api/service/emr/

@radeksimko radeksimko added the service/emr Issues and PRs that pertain to the emr service. label Jan 21, 2018
jmsantorum pushed a commit to jmsantorum/terraform-provider-aws that referenced this issue Feb 13, 2018
issue hashicorp#1146 - Extend EMR ec2_attributtes with subnet_ids, availability_zone, availability_zones. Added hadoop_version parameter.

issue hashicorp#1146 - Use EMR constants. Reuse EBS config schema to avoid redundancy. Updated EMR documentation
@copumpkin
Copy link

Another vote for this

@copumpkin
Copy link

Looks like there's a languishing PR for this, in case anyone wants to try it out: #1475

peay pushed a commit to peay/terraform-provider-aws that referenced this issue Sep 6, 2018
issue hashicorp#1146 - Extend EMR ec2_attributtes with subnet_ids, availability_zone, availability_zones. Added hadoop_version parameter.

issue hashicorp#1146 - Use EMR constants. Reuse EBS config schema to avoid redundancy. Updated EMR documentation
@darrenhaken
Copy link
Contributor

Is this just not being picked up?

@sanoojm
Copy link

sanoojm commented May 23, 2019

@darrenhaken @copumpkin @jmsantorum I have all the conflicts fixed and I have synced with the latest master. I am using it in my preprod environment as well. How do I proceed to update this PR? @jmsantorum, can you give me access to push a new branch to your repo? If anyone know a better way, please suggest.
Current PR: 1475

krish7919 pushed a commit to peay/terraform-provider-aws that referenced this issue Sep 18, 2019
issue hashicorp#1146 - Extend EMR ec2_attributtes with subnet_ids, availability_zone, availability_zones. Added hadoop_version parameter.

issue hashicorp#1146 - Use EMR constants. Reuse EBS config schema to avoid redundancy. Updated EMR documentation
@c4po
Copy link
Contributor

c4po commented Jun 25, 2020

Ok, I made another PR 13946 for this issue.
Please review.
We really need this feature in our EMR.
Once this merged, I will try add the EMR Managed Scaling feature.

@bostrowski13
Copy link

would be great to see this accepted and merged. looks like the work is done minus a PR and integration!

@anGie44 anGie44 linked a pull request Jul 22, 2020 that will close this issue
@bflad bflad self-assigned this Aug 22, 2020
@npinnaka
Copy link

+1

@bflad
Copy link
Contributor

bflad commented Aug 31, 2020

Support for new core_instance_fleet and master_instance_fleet configuration blocks in the aws_emr_cluster resource has been merged and will release with version 3.5.0 of the Terraform AWS Provider, later this week. Thanks to @c4po for the implementation. 👍

Support for task instance fleets, via a new aws_emr_instance_fleet resource, will be reviewed in the coming days.

@bflad bflad added this to the v3.5.0 milestone Sep 1, 2020
@bflad
Copy link
Contributor

bflad commented Sep 1, 2020

Support for the new aws_emr_instance_fleet resource has also been merged and will release with version 3.5.0 of the Terraform AWS Provider, likely on Thursday. Thanks again to @c4po for their efforts!

@bflad bflad closed this as completed Sep 1, 2020
@c4po
Copy link
Contributor

c4po commented Sep 1, 2020

thanks for the help @bflad 👏 🎉
I may have some other PRs for document and data source coming for review.

@ghost
Copy link

ghost commented Sep 3, 2020

This has been released in version 3.5.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/emr Issues and PRs that pertain to the emr service.
Projects
None yet
10 participants