Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing id documentation in aws_backup_plan #10392

Closed
julian-alarcon opened this issue Oct 4, 2019 · 3 comments · Fixed by #10441
Closed

Missing id documentation in aws_backup_plan #10392

julian-alarcon opened this issue Oct 4, 2019 · 3 comments · Fixed by #10441
Labels
documentation Introduces or discusses updates to documentation. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/backup Issues and PRs that pertain to the backup service.
Milestone
v2.32.0

Comments

@julian-alarcon
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform affected component

Web site: https://www.terraform.io/docs/providers/aws/r/backup_plan.html

Affected Resource(s)

  • aws_backup_plan

Expected Behaviour

Documentation indicating that id is one of the Attributes references should exist, similar to this:

id - The id of the plan.

Actual Behavior

No id documentation exists, I needed to figure it out.
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 4, 2019
bflad added a commit that referenced this issue Oct 6, 2019
@bflad
provider: Ensure hashibot performs issue labeling with backup, docdb,…
61a31b2 
… forecast, personalize, qldb, quicksight, and worklink services

Reference: #10392

Some of these were likely missed because they live in the GitHub Actions pull request labeling instead of hashibot (where the original list of copy-pasted from), but others are just newer GA services.
@bflad bflad added documentation Introduces or discusses updates to documentation. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/backup Issues and PRs that pertain to the backup service. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 6, 2019
@bflad bflad mentioned this issue Oct 6, 2019
Merged
@bflad
Copy link
Contributor

bflad commented Oct 6, 2019

Hi @julian-alarcon 👋 Thanks for filing this issue and sorry for the hassle. If you or anyone from the community is interested in fixing this, the documentation source lives within this repository at website/docs/r/backup_plan.html.markdown.

@davops davops mentioned this issue Oct 9, 2019
Merged
@bflad bflad added this to the v2.32.0 milestone Oct 9, 2019
@ghost
Copy link

ghost commented Oct 10, 2019

This has been released in version 2.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 9, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/backup Issues and PRs that pertain to the backup service.
Projects
None yet
Milestone
v2.32.0
Development

Successfully merging a pull request may close this issue.

updated the aws_backup_plan documentaiton to include the id
2 participants
@bflad @julian-alarcon