Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove terraform-provider-template dependency #10020

Closed
6 tasks
bflad opened this issue Sep 6, 2019 · 2 comments · Fixed by #10021
Closed
6 tasks

Remove terraform-provider-template dependency #10020

bflad opened this issue Sep 6, 2019 · 2 comments · Fixed by #10021
Labels
service/emr Issues and PRs that pertain to the emr service. service/lambda Issues and PRs that pertain to the lambda service. service/rds Issues and PRs that pertain to the rds service. service/ssm Issues and PRs that pertain to the ssm service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone
v2.30.0

Comments

@bflad
Copy link
Contributor

bflad commented Sep 6, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

There is limited usage of the template_file data source directly in our test configurations. Other than being an extra dependency with little benefit, most cases do not require the use of templating at all and can instead either use heredoc syntax or worst case the Terraform 0.12 built-in templatefile() function.

Definition of Done

  • aws/resource_aws_db_instance_test.go usage of template_file replaced or removed
  • aws/resource_aws_emr_cluster_test.go usage of template_file replaced or removed
  • aws/resource_aws_lambda_function_test.go usage of template_file replaced or removed
  • aws/resource_aws_ssm_maintenance_window_task_test.go usage of template_file replaced or removed
  • aws/provider_test.go template provider instantiation removed
  • github.com/terraform-providers/terraform-provider-template dependency removed from go.mod, go mod tidy and go mod vendor ran

References
@bflad bflad added service/lambda Issues and PRs that pertain to the lambda service. service/emr Issues and PRs that pertain to the emr service. service/rds Issues and PRs that pertain to the rds service. service/ssm Issues and PRs that pertain to the ssm service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Sep 6, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 6, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Sep 6, 2019
bflad added a commit that referenced this issue Sep 6, 2019
@bflad
deps: Remove github.com/terraform-providers/terraform-provider-template
ebd479e 
Reference: #10020

The `TestAccAWSDBInstance_diffSuppressInitialState` test removal is due to this functionality already being covered by this line in the `TestAccAWSDBInstance_basic` test: https://github.com/terraform-providers/terraform-provider-aws/blob/1cccd8185fbffa195a039768f65af85a9647c27e/aws/resource_aws_db_instance_test.go#L94

Output from acceptance testing:

```
--- PASS: TestAccAWSEMRCluster_bootstrap_ordering (383.33s)

--- PASS: TestAccAWSLambdaFunction_localUpdate (41.07s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (56.22s)

--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationStepFunctionParameters (17.37s)
--- PASS: TestAccAWSSSMMaintenanceWindowTask_TaskInvocationLambdaParameters (40.59s)
```
This was referenced Sep 6, 2019
Merged
Closed
@bflad bflad added this to the v2.30.0 milestone Sep 23, 2019
@ghost
Copy link

ghost commented Sep 26, 2019

This has been released in version 2.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
service/emr Issues and PRs that pertain to the emr service. service/lambda Issues and PRs that pertain to the lambda service. service/rds Issues and PRs that pertain to the rds service. service/ssm Issues and PRs that pertain to the ssm service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v2.30.0
1 participant
@bflad