Skip to content

Commit

Permalink
r/aws_ssm_parameter: Remove extraneous Exists function.
Browse files Browse the repository at this point in the history
  • Loading branch information
ewbankkit authored and appilon committed Apr 29, 2020
1 parent dd984b1 commit a4cd46d
Showing 1 changed file with 6 additions and 18 deletions.
24 changes: 6 additions & 18 deletions aws/resource_aws_ssm_parameter.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ func resourceAwsSsmParameter() *schema.Resource {
Read: resourceAwsSsmParameterRead,
Update: resourceAwsSsmParameterPut,
Delete: resourceAwsSsmParameterDelete,
Exists: resourceAwsSmmParameterExists,
Importer: &schema.ResourceImporter{
State: schema.ImportStatePassthrough,
},
Expand Down Expand Up @@ -93,22 +92,6 @@ func resourceAwsSsmParameter() *schema.Resource {
}
}

func resourceAwsSmmParameterExists(d *schema.ResourceData, meta interface{}) (bool, error) {
ssmconn := meta.(*AWSClient).ssmconn
_, err := ssmconn.GetParameter(&ssm.GetParameterInput{
Name: aws.String(d.Id()),
WithDecryption: aws.Bool(false),
})
if err != nil {
if isAWSErr(err, ssm.ErrCodeParameterNotFound, "") {
return false, nil
}
return false, err
}

return true, nil
}

func resourceAwsSsmParameterRead(d *schema.ResourceData, meta interface{}) error {
ssmconn := meta.(*AWSClient).ssmconn

Expand All @@ -118,8 +101,13 @@ func resourceAwsSsmParameterRead(d *schema.ResourceData, meta interface{}) error
Name: aws.String(d.Id()),
WithDecryption: aws.Bool(true),
})
if isAWSErr(err, ssm.ErrCodeParameterNotFound, "") {
log.Printf("[WARN] SSM Parameter (%s) not found, removing from state", d.Id())
d.SetId("")
return nil
}
if err != nil {
return fmt.Errorf("error getting SSM parameter: %s", err)
return fmt.Errorf("error reading SSM Parameter (%s): %w", d.Id(), err)
}

param := resp.Parameter
Expand Down

0 comments on commit a4cd46d

Please sign in to comment.