r/aws_glue_catalog_database: handle disappearing resources on delete (#…

…35195)

* r/aws_glue_catalog_database: handle disappearing resources on delete

Previously 'EntityNotFound' errors were not handled during deletion, resulting in a hard error message where the provider should instead proceed without error.

* chore: changelog

.changelog/35195.txt

@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_glue_catalog_database: Properly handle out-of-band resource deletion
+```

internal/service/glue/catalog_database.go

@@ -13,6 +13,7 @@ import (
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/aws/arn"
 	"github.com/aws/aws-sdk-go/service/glue"
+	"github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
@@ -282,6 +283,9 @@ func resourceCatalogDatabaseDelete(ctx context.Context, d *schema.ResourceData,
 		Name:      aws.String(d.Get("name").(string)),
 		CatalogId: aws.String(d.Get("catalog_id").(string)),
 	})
+	if tfawserr.ErrCodeEquals(err, glue.ErrCodeEntityNotFoundException) {
+		return diags
+	}
 	if err != nil {
 		return sdkdiag.AppendErrorf(diags, "deleting Glue Catalog Database (%s): %s", d.Id(), err)
 	}