Merge pull request #38737 from sumit-sampang-rai/s3-object-can-read-a…

…pplication-sql

s3 datasource aws_s3_object can read application/x-sql

.changelog/38737.txt

@@ -0,0 +1,7 @@
+```release-note:enhancement
+data-source/aws_s3_object: Expand content types that can be read from S3 to include `application/x-sql`
+```
+
+```release-note:enhancement
+data-source/aws_s3_bucket_object: Expand content types that can be read from S3 to include include `application/x-sql`
+```

internal/service/s3/object_data_source.go

@@ -284,6 +284,7 @@ func isContentTypeAllowed(contentType *string) bool {
 		regexache.MustCompile(`^application/x-sh$`),
 		regexache.MustCompile(`^application/xhtml\+xml$`),
 		regexache.MustCompile(`^application/xml$`),
+		regexache.MustCompile(`^application/x-sql$`),
 		regexache.MustCompile(`^text/.+`),
 	}
 	for _, r := range allowedContentTypes {

website/docs/d/s3_bucket_object.html.markdown

@@ -13,7 +13,20 @@ description: |-
 The S3 object data source allows access to the metadata and
 _optionally_ (see below) content of an object stored inside S3 bucket.
 
-~> **Note:** The content of an object (`body` field) is available only for objects which have a human-readable `Content-Type` (`text/*` and `application/json`). This is to prevent printing unsafe characters and potentially downloading large amount of data which would be thrown away in favor of metadata.
+~> **Note:** The content of an object (`body` field) is available only for objects which have a human-readable `Content-Type`:
+
+* `text/*`
+* `application/json`
+* `application/ld+json`
+* `application/x-httpd-php`
+* `application/xhtml+xml`
+* `application/x-csh`
+* `application/x-sh`
+* `application/xml`
+* `application/atom+xml`
+* `application/x-sql`
+
+This is to prevent printing unsafe characters and potentially downloading large amount of data which would be thrown away in favor of metadata.
 
 ## Example Usage
 

website/docs/d/s3_object.html.markdown

@@ -11,7 +11,20 @@ description: |-
 The S3 object data source allows access to the metadata and
 _optionally_ (see below) content of an object stored inside S3 bucket.
 
-~> **Note:** The content of an object (`body` field) is available only for objects which have a human-readable `Content-Type` (`text/*` and `application/json`). This is to prevent printing unsafe characters and potentially downloading large amount of data which would be thrown away in favor of metadata.
+~> **Note:** The content of an object (`body` field) is available only for objects which have a human-readable `Content-Type`:
+
+* `text/*`
+* `application/json`
+* `application/ld+json`
+* `application/x-httpd-php`
+* `application/xhtml+xml`
+* `application/x-csh`
+* `application/x-sh`
+* `application/xml`
+* `application/atom+xml`
+* `application/x-sql`
+
+This is to prevent printing unsafe characters and potentially downloading large amount of data which would be thrown away in favor of metadata.
 
 ## Example Usage