Skip to content

Commit

Permalink
Raise an error when failing to retrieve RDS instance tags
Browse files Browse the repository at this point in the history
Just logging the error means that if the user is unable to call the ListTagsForResource API endpoint then they will see a diff showing that they need to add the tags each time.
Instead it's better to actually error instead of hiding this from the user (unless they happen to check the logs).

Closes #345
  • Loading branch information
tomelliff committed Jun 22, 2018
1 parent 90b3032 commit 1f057f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion aws/resource_aws_db_instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,7 @@ func resourceAwsDbInstanceRead(d *schema.ResourceData, meta interface{}) error {
})

if err != nil {
log.Printf("[DEBUG] Error retrieving tags for ARN: %s", arn)
return fmt.Errorf("Error retrieving tags for ARN: %s", arn)
}

var dt []*rds.Tag
Expand Down

0 comments on commit 1f057f7

Please sign in to comment.