Skip to content

Commit

Permalink
Merge pull request #7059 from gliptak/secpol1
Browse files Browse the repository at this point in the history
Bring security policy current (ELBSecurityPolicy-2016-08)
  • Loading branch information
bflad authored Jan 8, 2019
2 parents b38299d + 555d609 commit 0d6a086
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
6 changes: 3 additions & 3 deletions aws/data_source_aws_lb_listener_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func TestAccDataSourceAWSLBListener_https(t *testing.T) {
resource.TestCheckResourceAttr("data.aws_lb_listener.front_end", "port", "443"),
resource.TestCheckResourceAttr("data.aws_lb_listener.front_end", "default_action.#", "1"),
resource.TestCheckResourceAttr("data.aws_lb_listener.front_end", "default_action.0.type", "forward"),
resource.TestCheckResourceAttr("data.aws_lb_listener.front_end", "ssl_policy", "ELBSecurityPolicy-2015-05"),
resource.TestCheckResourceAttr("data.aws_lb_listener.front_end", "ssl_policy", "ELBSecurityPolicy-2016-08"),
resource.TestCheckResourceAttrSet("data.aws_lb_listener.from_lb_and_port", "load_balancer_arn"),
resource.TestCheckResourceAttrSet("data.aws_lb_listener.from_lb_and_port", "arn"),
resource.TestCheckResourceAttrSet("data.aws_lb_listener.from_lb_and_port", "default_action.0.target_group_arn"),
Expand All @@ -98,7 +98,7 @@ func TestAccDataSourceAWSLBListener_https(t *testing.T) {
resource.TestCheckResourceAttr("data.aws_lb_listener.from_lb_and_port", "port", "443"),
resource.TestCheckResourceAttr("data.aws_lb_listener.from_lb_and_port", "default_action.#", "1"),
resource.TestCheckResourceAttr("data.aws_lb_listener.from_lb_and_port", "default_action.0.type", "forward"),
resource.TestCheckResourceAttr("data.aws_lb_listener.from_lb_and_port", "ssl_policy", "ELBSecurityPolicy-2015-05"),
resource.TestCheckResourceAttr("data.aws_lb_listener.from_lb_and_port", "ssl_policy", "ELBSecurityPolicy-2016-08"),
),
},
},
Expand Down Expand Up @@ -336,7 +336,7 @@ resource "aws_lb_listener" "front_end" {
load_balancer_arn = "${aws_lb.alb_test.id}"
protocol = "HTTPS"
port = "443"
ssl_policy = "ELBSecurityPolicy-2015-05"
ssl_policy = "ELBSecurityPolicy-2016-08"
certificate_arn = "${aws_iam_server_certificate.test_cert.arn}"
default_action {
Expand Down
2 changes: 1 addition & 1 deletion aws/resource_aws_lb_listener_certificate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ resource "aws_lb_listener" "test" {
load_balancer_arn = "${aws_lb.test.arn}"
port = "443"
protocol = "HTTPS"
ssl_policy = "ELBSecurityPolicy-2015-05"
ssl_policy = "ELBSecurityPolicy-2016-08"
certificate_arn = "${aws_iam_server_certificate.default.arn}"
default_action {
Expand Down
6 changes: 3 additions & 3 deletions aws/resource_aws_lb_listener_rule_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1654,7 +1654,7 @@ resource "aws_lb_listener" "front_end" {
load_balancer_arn = "${aws_lb.alb_test.id}"
protocol = "HTTPS"
port = "443"
ssl_policy = "ELBSecurityPolicy-2015-05"
ssl_policy = "ELBSecurityPolicy-2016-08"
certificate_arn = "${aws_iam_server_certificate.test.arn}"
default_action {
Expand Down Expand Up @@ -1832,7 +1832,7 @@ resource "aws_lb_listener" "front_end" {
load_balancer_arn = "${aws_lb.alb_test.id}"
protocol = "HTTPS"
port = "443"
ssl_policy = "ELBSecurityPolicy-2015-05"
ssl_policy = "ELBSecurityPolicy-2016-08"
certificate_arn = "${aws_iam_server_certificate.test.arn}"
default_action {
Expand Down Expand Up @@ -1997,7 +1997,7 @@ resource "aws_lb_listener" "test" {
load_balancer_arn = "${aws_lb.test.id}"
protocol = "HTTPS"
port = "443"
ssl_policy = "ELBSecurityPolicy-2015-05"
ssl_policy = "ELBSecurityPolicy-2016-08"
certificate_arn = "${aws_iam_server_certificate.test.arn}"
default_action {
Expand Down
10 changes: 5 additions & 5 deletions aws/resource_aws_lb_listener_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func TestAccAWSLBListener_https(t *testing.T) {
resource.TestCheckResourceAttr("aws_lb_listener.front_end", "default_action.0.redirect.#", "0"),
resource.TestCheckResourceAttr("aws_lb_listener.front_end", "default_action.0.fixed_response.#", "0"),
resource.TestCheckResourceAttrSet("aws_lb_listener.front_end", "certificate_arn"),
resource.TestCheckResourceAttr("aws_lb_listener.front_end", "ssl_policy", "ELBSecurityPolicy-2015-05"),
resource.TestCheckResourceAttr("aws_lb_listener.front_end", "ssl_policy", "ELBSecurityPolicy-2016-08"),
),
},
},
Expand Down Expand Up @@ -584,7 +584,7 @@ func testAccAWSLBListenerConfig_https(lbName, targetGroupName string) string {
load_balancer_arn = "${aws_lb.alb_test.id}"
protocol = "HTTPS"
port = "443"
ssl_policy = "ELBSecurityPolicy-2015-05"
ssl_policy = "ELBSecurityPolicy-2016-08"
certificate_arn = "${aws_iam_server_certificate.test_cert.arn}"
default_action {
Expand Down Expand Up @@ -1004,7 +1004,7 @@ resource "aws_lb_listener" "test" {
load_balancer_arn = "${aws_lb.test.id}"
protocol = "HTTPS"
port = "443"
ssl_policy = "ELBSecurityPolicy-2015-05"
ssl_policy = "ELBSecurityPolicy-2016-08"
certificate_arn = "${aws_iam_server_certificate.test.arn}"
default_action {
Expand Down Expand Up @@ -1131,7 +1131,7 @@ resource "aws_lb_listener" "test" {
load_balancer_arn = "${aws_lb.test.id}"
protocol = "HTTPS"
port = "443"
ssl_policy = "ELBSecurityPolicy-2015-05"
ssl_policy = "ELBSecurityPolicy-2016-08"
certificate_arn = "${aws_iam_server_certificate.test.arn}"
default_action {
Expand Down Expand Up @@ -1170,7 +1170,7 @@ resource "aws_lb_listener" "test" {
load_balancer_arn = "${aws_lb.test.id}"
protocol = "HTTPS"
port = "443"
ssl_policy = "ELBSecurityPolicy-2015-05"
ssl_policy = "ELBSecurityPolicy-2016-08"
certificate_arn = "${aws_iam_server_certificate.test.arn}"
default_action {
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/lb_listener.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ resource "aws_lb_listener" "front_end" {
load_balancer_arn = "${aws_lb.front_end.arn}"
port = "443"
protocol = "HTTPS"
ssl_policy = "ELBSecurityPolicy-2015-05"
ssl_policy = "ELBSecurityPolicy-2016-08"
certificate_arn = "arn:aws:iam::187416307283:server-certificate/test_cert_rab3wuqwgja25ct3n4jdj2tzu4"
default_action {
Expand Down

0 comments on commit 0d6a086

Please sign in to comment.