generated from hashicorp/terraform-provider-scaffolding-framework
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve not_null
and null
functions
#83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
new-function
Pull requests that update or introduce new functions
tests
labels
Jan 3, 2025
bschaatsbergen
removed
the
new-function
Pull requests that update or introduce new functions
label
Jan 3, 2025
bschaatsbergen
force-pushed
the
b/fix-null-functions
branch
from
January 3, 2025 15:03
2985981
to
c88fd10
Compare
github-actions
bot
added
the
new-function
Pull requests that update or introduce new functions
label
Jan 3, 2025
bschaatsbergen
force-pushed
the
b/fix-null-functions
branch
from
January 3, 2025 15:04
c88fd10
to
eb178d0
Compare
bschaatsbergen
removed
the
new-function
Pull requests that update or introduce new functions
label
Jan 3, 2025
github-actions
bot
added
github-actions
Pull requests that update GitHub Actions code
new-function
Pull requests that update or introduce new functions
labels
Jan 3, 2025
bschaatsbergen
removed
the
new-function
Pull requests that update or introduce new functions
label
Jan 3, 2025
austinvalle
reviewed
Jan 3, 2025
github-actions
bot
added
the
new-function
Pull requests that update or introduce new functions
label
Jan 3, 2025
Unknown values could ultimately resolve to null or a valid value, so it’s best to avoid accepting them.
bschaatsbergen
added
bug
Something isn't working
and removed
new-function
Pull requests that update or introduce new functions
labels
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
Fixes #71
null
checks whether the DynamicValue represents a literalnull
with no known type. This behavior conflicted with cross-object validation, where the type is known, and the underlying value needs to be checked to see if it evaluates to null. 9725ed fixes this.not_null
, we’re enabling cross-object validation by first determining if we’re dealing with a literalnull
value. If not, the underlying value is then checked to confirm whether it isnull
or not.