Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tfexec to v0.18.1 + add tests for ExpectError #86

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

austinvalle
Copy link
Member

@austinvalle austinvalle commented Mar 1, 2023

Background

A recent update of tfexecv0.18.0 caused a regression where detailed stderr information wasn't being passed to this testing module. This has now been fixed with the new release v0.18.1

Notes

@austinvalle austinvalle marked this pull request as ready for review March 1, 2023 13:53
@austinvalle austinvalle requested a review from a team as a code owner March 1, 2023 13:53
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@austinvalle austinvalle merged commit b65227b into main Mar 1, 2023
@austinvalle austinvalle deleted the av/add-error-test branch March 1, 2023 14:02
@github-actions
Copy link

github-actions bot commented Apr 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants