Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport remaining fixes from v2.0.3. #590

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Conversation

paddycarver
Copy link
Contributor

Backport #580 to restore pre-binary ExpectNonEmptyPlan behavior when
testing.

Backport #584 to use the latest terraform-exec and terraform-plugin-test
to take advantage of the fixed diff output.

Backport #581 to check the error on post-test destroy, warning there may
be dangling resources and surfacing the error.

This should bring the v1-maint branch in line with 2.0.3 in terms of
functionality and bug fixes.

@paddycarver paddycarver added bug Something isn't working testing labels Sep 22, 2020
@paddycarver paddycarver requested a review from a team September 22, 2020 09:42
Backport #580 to restore pre-binary ExpectNonEmptyPlan behavior when
testing.

Backport #584 to use the latest terraform-exec and terraform-plugin-test
to take advantage of the fixed diff output.

Backport #581 to check the error on post-test destroy, warning there may
be dangling resources and surfacing the error.

This should bring the v1-maint branch in line with 2.0.3 in terms of
functionality and bug fixes.
@paddycarver paddycarver merged commit f492025 into v1-maint Sep 23, 2020
@paddycarver paddycarver deleted the v1-v2.0.3-backports branch September 23, 2020 08:37
@ghost
Copy link

ghost commented Oct 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants