Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use wd.SetReattachInfo #567

Merged
merged 2 commits into from
Sep 9, 2020
Merged

use wd.SetReattachInfo #567

merged 2 commits into from
Sep 9, 2020

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Sep 7, 2020

Needs hashicorp/terraform-plugin-test#38

Propagating the reattach info is now managed by tftest.WorkingDir instead of the shell environment.

@kmoe kmoe requested a review from paddycarver September 7, 2020 21:35
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WorkingDir is specific to each TestCase? So there wouldn't ever be a race due to t.Parallel or something? Otherwise, LGTM

@paddycarver
Copy link
Contributor

Yeah, a new one is created for every runNewTest, which is invoked by resource.Test, so this should be unique per TestCase and should not be subject to parallelism.

@kmoe kmoe merged commit 461847f into master Sep 9, 2020
@kmoe kmoe deleted the reattach-env branch September 9, 2020 20:32
paddycarver added a commit that referenced this pull request Sep 9, 2020
paddycarver added a commit that referenced this pull request Sep 10, 2020
paddycarver added a commit that referenced this pull request Sep 10, 2020
@ghost
Copy link

ghost commented Oct 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants