Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Modify CallFunction implementations #1316

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

bendbennett
Copy link
Contributor

@bendbennett bendbennett commented Feb 23, 2024

Reference: hashicorp/terraform-plugin-go#380
Reference: https://developer.hashicorp.com/terraform/plugin/framework/migrating
Reference: https://github.com/hashicorp/terraform-providers-devex-internal/issues/175

The next versions of the plugin protocol (5.5/6.5) include support for provider defined functions. The terraform-plugin-sdk Go module will not be receiving this feature, however this Go module must be updated to handle the new RPC with errors.

Provider developers can implement provider defined functions by introducing terraform-plugin-mux and using their terraform-plugin-sdk based providers in combination with a terraform-plugin-framework provider that contains the provider defined functions.

Reference: hashicorp/terraform-plugin-go#380
Reference: https://developer.hashicorp.com/terraform/plugin/framework/migrating

The next versions of the plugin protocol (5.5/6.5) include support for provider defined functions. The terraform-plugin-sdk Go module will not be receiving this feature, however this Go module must be updated to handle the new RPC with errors.

Provider developers can implement provider defined functions by introducing terraform-plugin-mux and using their terraform-plugin-sdk based providers in combination with a terraform-plugin-framework provider that contains the provider defined functions.
@bendbennett bendbennett added the enhancement New feature or request label Feb 23, 2024
@bendbennett bendbennett added this to the v2.33.0 milestone Feb 23, 2024
@bendbennett bendbennett requested a review from a team as a code owner February 23, 2024 10:52
@@ -14,7 +14,7 @@ require (
github.com/hashicorp/logutils v1.0.0
github.com/hashicorp/terraform-exec v0.20.0
github.com/hashicorp/terraform-json v0.21.0
github.com/hashicorp/terraform-plugin-go v0.21.0
github.com/hashicorp/terraform-plugin-go v0.22.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running go get github.com/hashicorp/terraform-plugin-go results in the addition of the following entry to go.mod:

toolchain go1.21.6

Which would result in an analogous CI failure to that seen on terraform-plugin-mux

Given that our CI runs both Go 1.20 and 1.21, I removed this directive, but perhaps this should be handled differently?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing it is okay for now -- or can just let Dependabot own the update.

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@bendbennett bendbennett merged commit 70fb6b9 into main Feb 23, 2024
7 of 8 checks passed
@bendbennett bendbennett deleted the bendbennett/pdf-error-handling branch February 23, 2024 14:27
Copy link

github-actions bot commented Apr 3, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants