Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax InternalValidate on the ID attribute #607

Closed
paultyng opened this issue Oct 7, 2020 · 1 comment · Fixed by #613
Closed

Relax InternalValidate on the ID attribute #607

paultyng opened this issue Oct 7, 2020 · 1 comment · Fixed by #613
Labels
enhancement New feature or request

Comments

@paultyng
Copy link
Contributor

paultyng commented Oct 7, 2020

As long as the the explicit schema of an ID attribute conforms to some specific values (maybe only type of string, unsure), it should be allowed to be overridden.

There are a few different use cases (document generation, LS, schema JSON), but mostly they stem from the fact that its always set to Optional + Computed even if its not actually optional for resource.

@paultyng paultyng added the enhancement New feature or request label Oct 7, 2020
paultyng added a commit that referenced this issue Oct 13, 2020
paultyng added a commit that referenced this issue Oct 13, 2020
paultyng added a commit that referenced this issue Oct 13, 2020
paultyng added a commit that referenced this issue Oct 14, 2020
@ghost
Copy link

ghost commented Nov 14, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant