Error returned from CheckDestroy is ignored

[lsierant]

SDK version

v2.0.1

Relevant provider source code

In helper/resource/testing_new.go result from runPostTestDestroy is ignored:

func runNewTest(t testing.T, c TestCase, helper *tftest.Helper) {
// ...
    if !stateIsEmpty(statePreDestroy) {
        runPostTestDestroy(t, c, wd, c.ProviderFactories)
    }

runPostTestDestroy invokes CheckDestroy and bubbles up the error.

Expected Behavior

When CheckDestroy function returns an error, test should fail. Error returned from CheckDestroy indicates that some resources still exist or there was a problem deleting it.

Actual Behavior

Test is passing despite returning error from CheckDestroy.

Steps to Reproduce

1. Return an error in any CheckDestroy function.
2. Tests still will pass.

References

Change was introduced in April in #356 and #393. Fix is trivial:

    if !stateIsEmpty(statePreDestroy) {
        if err := runPostTestDestroy(t, c, wd, c.ProviderFactories); err != nil {
            t.Fatal(err)
        }
    }

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.