Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Denote Which Versions of Framework/SDK Are Required #57

Closed
4 of 6 tasks
bflad opened this issue May 3, 2022 · 1 comment · Fixed by #80
Closed
4 of 6 tasks

Denote Which Versions of Framework/SDK Are Required #57

bflad opened this issue May 3, 2022 · 1 comment · Fixed by #80
Assignees
@bflad
Labels
documentation Improvements or additions to documentation
Milestone
v0.6.0

Comments

@bflad
Copy link
Contributor

bflad commented May 3, 2022

Does this documenation exist?

  • This is new documentation
  • This is an enhancement to existing documentation

Where would you expect to find this documentation?

  • On terraform.io
  • In the GoDoc for this module
  • In this repo as a markdown file
  • Somewhere else

Details

Properly using tflog requires the SDKs to provide a setup context.Context, otherwise logs just won't show up currently due to #52. This means that providers need to depend on SDKs at least at the version that added terraform-plugin-log support:

  • terraform-plugin-framework v0.6.0
  • terraform-plugin-sdk v2.10.0
@bflad bflad added the documentation Improvements or additions to documentation label May 3, 2022
@bflad bflad self-assigned this Jul 15, 2022
@bflad bflad added this to the v0.6.0 milestone Jul 15, 2022
bflad added a commit that referenced this issue Jul 15, 2022
@bflad
website: Add tflog requirements section and legacy logging section
3bb41e9 
Reference: #57
Reference: hashicorp/terraform-plugin-sdk#863

This also makes some minor fixes to use recently updated `SetField()` function names.
@bflad bflad mentioned this issue Jul 15, 2022
Merged
@bflad bflad closed this as completed in #80 Jul 15, 2022
bflad added a commit that referenced this issue Jul 15, 2022
@bflad
website: Add tflog requirements section and legacy logging section (#80)
60509c8 
Reference: #57
Reference: hashicorp/terraform-plugin-sdk#863

This also makes some minor fixes to use recently updated `SetField()` function names and further standardizes on logging "field" terminology over "variable" or "argument".
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

website: Add tflog requirements section and legacy logging section hashicorp/terraform-plugin-log
1 participant
@bflad