Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tfprotov5+tfprotov6: Require EphemeralResourceServer in ProviderServer #465

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

austinvalle
Copy link
Member

@austinvalle austinvalle commented Jan 21, 2025

Closes #442

This PR makes EphemeralResourceServer a required implementation for downstream provider servers, which reflects the protocol implementation.

@austinvalle austinvalle added this to the v0.26.0 milestone Jan 21, 2025
@austinvalle austinvalle added the breaking-change This will impact or improve our compatibility posture label Jan 21, 2025
@austinvalle
Copy link
Member Author

Once we merge hashicorp/terraform-provider-corner#299, the CI errors can be resolved 👍🏻

@austinvalle
Copy link
Member Author

I mistakenly added ProviderServerWithEphemeralResources when it wasn't really needed, however I double checked our downstream Go modules and the only one referencing this interface are some unit tests in terraform-plugin-mux (which should just be referencing EphemeralResourceServer) 😔

Since these are isolated to a _test package and _test.go files, they shouldn't affect the builds of providers that are upgrading terraform-plugin-go. Since we have already implemented the ephemeral resource RPCs in terraform-plugin-testing, terraform-plugin-sdk/v2 and terraform-plugin-framework, we should be good to remove this interface in the upcoming v0.26.0 release of this Go module.

Double checked this by locally updating the dns provider (muxed) and time provider (not muxed) and both pass builds with an updated terraform-plugin-go@933709cd4c2b68a7f5e5b9932f76d68b41cfe6ed and the following Go module versions:

@austinvalle austinvalle marked this pull request as ready for review January 21, 2025 23:15
@austinvalle austinvalle requested a review from a team as a code owner January 21, 2025 23:15
@SBGoods SBGoods merged commit 7ff6ef6 into main Jan 22, 2025
90 checks passed
@SBGoods SBGoods deleted the av/issue-442 branch January 22, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will impact or improve our compatibility posture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tfprotov5+tfprotov6: Add EphemeralResourceServer to ProviderServer interface
2 participants