tfprotov5+tfprotov6: Write-only Attribute Implementation #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibutes and generate stubs.
…ename `PriorState` request fields to `State`.
…ibutes and generate stubs.
…nto SBGoods/write-only-attributes
…tributes # Conflicts: # tfprotov5/internal/tfplugin5/tfplugin5.pb.go # tfprotov6/internal/tfplugin6/tfplugin6.pb.go
# Conflicts: # tfprotov5/ephemeral_resource.go # tfprotov5/internal/fromproto/ephemeral_resource.go # tfprotov5/internal/fromproto/ephemeral_resource_test.go # tfprotov5/internal/tfplugin5/tfplugin5.pb.go # tfprotov5/internal/tfplugin5/tfplugin5.proto # tfprotov5/internal/tfplugin5/tfplugin5_grpc.pb.go # tfprotov5/internal/toproto/ephemeral_resource.go # tfprotov5/internal/toproto/ephemeral_resource_test.go # tfprotov5/tf5server/server.go # tfprotov6/ephemeral_resource.go # tfprotov6/internal/fromproto/ephemeral_resource.go # tfprotov6/internal/fromproto/ephemeral_resource_test.go # tfprotov6/internal/tfplugin6/tfplugin6.pb.go # tfprotov6/internal/tfplugin6/tfplugin6.proto # tfprotov6/internal/tfplugin6/tfplugin6_grpc.pb.go # tfprotov6/internal/toproto/ephemeral_resource.go # tfprotov6/internal/toproto/ephemeral_resource_test.go # tfprotov6/tf6server/server.go
…or validate resource config
# Conflicts: # tfprotov5/internal/tfplugin5/tfplugin5.pb.go # tfprotov6/internal/tfplugin6/tfplugin6.pb.go
austinvalle
previously approved these changes
Jan 21, 2025
| @@ -3,6 +3,15 @@ | |||
|
|
|||
| package tfprotov5 | |||
|
|
|||
| // ValidateResourceTypeConfigClientCapabilities allows Terraform to publish information | |||
There was a problem hiding this comment.
My monthly reminder that this RPC is named different in protocol v5 😆
There was a problem hiding this comment.
Not specific feedback to this work, more of an observation, but I see that Terraform core is sending these client capabilities in every RPC request regardless of whether we use them. So in theory we could add, say, the WriteOnlyAttributesAllowed capability to PlanResourceChange with an SDK only change.
Not saying we should, but thought it was interesting.
Co-authored-by: Austin Valle <[email protected]>
austinvalle
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next version of the plugin protocol (5.8/6.8) introduces a new
write_onlyproperty to theSchema.Attributemessage to specify a write-only attribute. Write-only attributes are attributes which do not have their values persisted to Terraform state.write_onlyis only applicable for managed resource attributes.