Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tfprotov5+tfprotov6: Add DynamicValue type IsNull method #306

Merged
merged 1 commit into from
Jun 28, 2023
Merged

tfprotov5+tfprotov6: Add DynamicValue type IsNull method #306

merged 1 commit into from
Jun 28, 2023

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 27, 2023

Closes #305

@bflad bflad added the enhancement New feature or request label Jun 27, 2023
@bflad bflad added this to the v0.17.0 milestone Jun 27, 2023
@bflad bflad requested a review from a team as a code owner June 27, 2023 17:01
bendbennett
bendbennett approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bendbennett bendbennett mentioned this pull request Jun 28, 2023
Merged
@bflad bflad merged commit e339254 into main Jun 28, 2023
@bflad bflad deleted the bflad/dynamicvalue-isnull branch June 28, 2023 14:25
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

tfprotov5+tfprotov6: Add DynamicValue Null Checking Without Type Information
2 participants
@bflad @bendbennett