Minor fix to stringvalidator.LengthBetween()
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go doc comment now more accurately reflects the validator behavior. An unnecessary validation (max cannot be less than zero) was removed.
chrismarget
changed the title
LengthBetween()stringvalidator.LengthBetween()
|
Hi @chrismarget 👋 Thank you for the PR. Could I ask that you add a couple of tests to verify that the "greater than or equal to" conditions are met for both |
|
Hi @bendbennett, I think 00165d6 has what you're looking for. |
bendbennett
approved these changes
Aug 21, 2023
Suggested change from @bendbennett Co-authored-by: Benjamin Bennett <[email protected]>
Suggested change from @bendbennett Co-authored-by: Benjamin Bennett <[email protected]>
|
Thanks for the contribution @chrismarget 👍 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote some bugs by relying on
LengthBetween()'s Go doc comment.The Go doc comment now more accurately reflects the validator behavior.
An unnecessary validation (max cannot be less than zero, even without this check) was removed.