build: Sign archives checksum #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
changed the title
|
Considering our historic bundling of the HC public key in TF, its probably safe to bundle it in the VSCode extension. We can discuss further internally though what the best strategy is. |
paultyng
approved these changes
May 14, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for #49 as we can't publish any artifacts to releases.hashicorp.com without the signature.
cc @aeschright - FYI we could also verify the signature when installing the LS in VSCode. I'm just not sure what's the best workflow there and whether to bundle the pubkey (probably more secure, less convenient for potential updates) or pull it down from somewhere on demand (theoretically less secure, but more convenient for updates).