Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Decouple the code from the terraform version. #77

Merged
merged 4 commits into from
Oct 27, 2020
Merged

Conversation

koikonom
Copy link
Contributor

Instead of parsing the state in order to extract the outputs we call the
TFE API to get the same information. That way we don't need to pull
terraform as a dependency.

How to test

Create a workspace as usual and verify in TFC that the workspace is using the latest version of TF available.

Additionally set the key terraformVersion in your workspace definition to set an older terraform version.

Instead of parsing the state in order to extract the outputs we call the
TFE API to get the same information.  That way we don't need to pull
terraform as a dependency.
@koikonom
Copy link
Contributor Author

Fixes #64

@koikonom koikonom changed the title Decouple the code from the terraform version. [WIP] Decouple the code from the terraform version. Oct 21, 2020
@koikonom koikonom changed the title [WIP] Decouple the code from the terraform version. Decouple the code from the terraform version. Oct 21, 2020
@koikonom koikonom requested a review from a team October 21, 2020 20:08
Copy link
Contributor

@dak1n1 dak1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work! It's nice to get rid of that hard-coded version requirement.

I tested this out and it works for me in TFE, both with and without the version set in the Workspace CR. So that looks great!

pkg/controller/workspace/tfc_org.go Outdated Show resolved Hide resolved
@koikonom koikonom merged commit 7432393 into master Oct 27, 2020
@koikonom koikonom deleted the tf_version branch October 27, 2020 21:38
@koikonom
Copy link
Contributor Author

Closes #64

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants