Fixed typing of check results in statefiles #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR also improves on the has_checks test by using some real data, ensuring that both the statefile and the plan files can be parsed correctly.
|
|
liamcervante
approved these changes
Aug 30, 2023
AislingHPE
added a commit
to AislingHPE/tofu-exec
that referenced
this pull request
May 30, 2024
There is an issue in v0.17.1 of terrraform-json where state files can't be read when there are checks present, since checks are an arrray, and the tool tries to marshal them to a strruct. This causes an issue with the ShowStateFile function. Bumping terraform-json to the latest version and running `go mod tidy` to pull in its dependencies. Original issue in tfexec: hashicorp#415 Line which doesn't work currently in this repo: https://github.com/opentofu/tofu-exec/blob/e5963f176ec5f21e5d059428189439290554c25c/tfexec/show.go#L95-L99 Patch to terraform-json: hashicorp/terraform-json#101 Changlog from v0.17.1 to v0.22.1: https://github.com/hashicorp/terraform-json/releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also improves on the has_checks test by using some real data, ensuring that both the statefile and the plan files can be parsed correctly.