add ReattachOption #78
Merged
+372
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultyng
reviewed
Sep 8, 2020
paultyng
reviewed
Sep 8, 2020
|
Some comments inline, also need a compatibility check for 0.12.26 or greater |
|
I agree with all @paultyng's comments, and have no other comments of my own to add. 👍 |
paultyng
reviewed
Sep 9, 2020
paultyng
reviewed
Sep 9, 2020
paultyng
reviewed
Sep 9, 2020
paultyng
reviewed
Sep 9, 2020
paultyng
reviewed
Sep 9, 2020
paultyng
reviewed
Sep 9, 2020
paultyng
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary testing reattach functionality requires the
TF_PROVIDERS_REATTACHenv var to be present in the environment in which the Terraform CLI is run. In normal usage, such as in terraform-plugin-test, the value of this env var will change during the lifetime of a*Terraform. We therefore provide a way of setting the reattach info string on every relevant Terraform CLI command as if it is an option.