Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add well known error for required_version issues #66

Merged
merged 1 commit into from
Sep 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tfexec/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ func (tf *Terraform) runTerraformCmd(cmd *exec.Cmd) error {

err := cmd.Run()
if err != nil {
return parseError(err, errBuf.String())
return tf.parseError(err, errBuf.String())
}
return nil
}
Expand Down
43 changes: 42 additions & 1 deletion tfexec/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,42 @@ var (
workspaceDoesNotExistRegexp = regexp.MustCompile(`Workspace "(.+)" doesn't exist.`)

workspaceAlreadyExistsRegexp = regexp.MustCompile(`Workspace "(.+)" already exists`)

tfVersionMismatchErrRegexp = regexp.MustCompile(`Error: The currently running version of Terraform doesn't meet the|Error: Unsupported Terraform Core version`)
tfVersionMismatchConstraintRegexp = regexp.MustCompile(`required_version = "(.+)"|Required version: (.+)\b`)
)

func parseError(err error, stderr string) error {
func (tf *Terraform) parseError(err error, stderr string) error {
if _, ok := err.(*exec.ExitError); !ok {
return err
}

switch {
case tfVersionMismatchErrRegexp.MatchString(stderr):
constraint := ""
constraints := tfVersionMismatchConstraintRegexp.FindStringSubmatch(stderr)
for i := 1; i < len(constraints); i++ {
constraint = strings.TrimSpace(constraints[i])
if constraint != "" {
break
}
}

if constraint == "" {
// hardcode a value here for weird cases (incl. 0.12)
constraint = "unknown"
}

// only set this if it happened to be cached already
ver := ""
if tf != nil && tf.execVersion != nil {
ver = tf.execVersion.String()
}

return &ErrTFVersionMismatch{
Constraint: constraint,
TFVersion: ver,
}
case missingVarErrRegexp.MatchString(stderr):
name := ""
names := missingVarNameRegexp.FindStringSubmatch(stderr)
Expand Down Expand Up @@ -70,6 +98,19 @@ func (e *ErrNoSuitableBinary) Error() string {
return fmt.Sprintf("no suitable terraform binary could be found: %s", e.err.Error())
}

// ErrTFVersionMismatch is returned when the running Terraform version is not compatible with the
// value specified for required_version in the terraform block.
type ErrTFVersionMismatch struct {
TFVersion string

// Constraint is not returned in the error messaging on 0.12
Constraint string
}

func (e *ErrTFVersionMismatch) Error() string {
return "terraform core version not supported by configuration"
}

// ErrVersionMismatch is returned when the detected Terraform version is not compatible with the
// command or flags being used in this invocation.
type ErrVersionMismatch struct {
Expand Down
29 changes: 29 additions & 0 deletions tfexec/internal/e2etest/errors_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,32 @@ func TestMissingVar(t *testing.T) {
}
})
}

func TestTFVersionMismatch(t *testing.T) {
runTest(t, "tf99", func(t *testing.T, tfv *version.Version, tf *tfexec.Terraform) {
// force cache version for error messaging
_, _, err := tf.Version(context.Background(), true)
if err != nil {
t.Fatal(err)
}

err = tf.Init(context.Background())
if err == nil {
t.Fatal("expected error, but didn't find one")
}

var e *tfexec.ErrTFVersionMismatch
if !errors.As(err, &e) {
t.Fatalf("expected ErrTFVersionMismatch, got %T, %s", err, err)
}

// in 0.12, we just return "unknown" as the specifics are not included in the error messaging
if e.Constraint != "unknown" && e.Constraint != ">99.0.0" {
t.Fatalf("unexpected constraint %q", e.Constraint)
}

if e.TFVersion != tfv.String() {
t.Fatalf("expected %q, got %q", tfv.String(), e.TFVersion)
}
})
}
3 changes: 3 additions & 0 deletions tfexec/internal/e2etest/testdata/tf99/main.tf
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
terraform {
required_version = ">99.0.0"
}