tfexec: Add (Terraform).SetLog() method #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
reviewed
May 16, 2022
There was a problem hiding this comment.
The implementation looks good to me but can you also add a test which confirms the right ENV vars are being set after SetLog is called?
https://github.com/hashicorp/terraform-exec/blob/main/tfexec/terraform_test.go
Thanks!
bflad
force-pushed
the
bflad-tfexec-terraform-setlog
branch
from
10402aa to
47e6c29
Compare
|
Rebased and pushed up environment variable testing for both |
…updates for darwin/arm64
rstandt
pushed a commit
to rstandt/terraform-exec
that referenced
this pull request
Jun 21, 2022
* tfexec: Add (Terraform).SetLog() method Reference: hashicorp#290 * tfexec: Add testing for SetLog * tfexec: Add SetLogPath testing * tfexec: Ensure SetLog version compatibility is 0.15 minimum, testing updates for darwin/arm64
bflad
added a commit
to hashicorp/terraform-plugin-sdk
that referenced
this pull request
Jun 30, 2022
…erraform during acceptance testing on versions 0.15 and later Reference: hashicorp/terraform-exec#291 Reference: #992 This allows the acceptance testing framework to appropriately set the `TF_LOG` environment variable via `terraform-exec`, if Terraform is version 0.15 or later. Otherwise, defaults to `TRACE` similar to before when `TF_ACC_LOG_PATH` or `TF_LOG_PATH_MASK` environment variables are set.
bflad
added a commit
to hashicorp/terraform-plugin-sdk
that referenced
this pull request
Jul 1, 2022
…erraform during acceptance testing on versions 0.15 and later Reference: hashicorp/terraform-exec#291 Reference: #992 This allows the acceptance testing framework to appropriately set the `TF_LOG` environment variable via `terraform-exec`, if Terraform is version 0.15 or later. Otherwise, defaults to `TRACE` similar to before when `TF_ACC_LOG_PATH` or `TF_LOG_PATH_MASK` environment variables are set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #290