Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix force-copy #268

Merged
merged 1 commit into from
Aug 18, 2022
Merged

fix force-copy #268

merged 1 commit into from
Aug 18, 2022

Conversation

chanwit
Copy link
Contributor

@chanwit chanwit commented Jan 18, 2022

This PR fixes unconfigurable force-copy, and change its default value to be false.

Fixes #262

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 18, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Nalum
Copy link

Nalum commented Jul 29, 2022

Any chance of getting this in?

@Nalum Nalum mentioned this pull request Aug 2, 2022
Merged
kmoe
kmoe approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR - this was indeed an oversight and I agree with the fix.

The test failures should be fixed if you rebase your branch on main. I'll merge once tests pass.

@chanwit chanwit force-pushed the release-0.15 branch 3 times, most recently from 1f54621 to 229a909 Compare August 12, 2022 16:49
@chanwit
Copy link
Contributor Author

chanwit commented Aug 12, 2022

Thank you @kmoe
I'm working on it.

@chanwit
fix force-copy
cec688e 
Signed-off-by: Chanwit Kaewkasi <[email protected]>
@chanwit
Copy link
Contributor Author

chanwit commented Aug 12, 2022

Hi again @kmoe
It seems all tests passed, except the mac OS as it could not spin up the test environment.

@kmoe
Copy link
Member

kmoe commented Aug 18, 2022

The macosbuildtest failure is unrelated to this PR and fixed in main, so I am merging this.

@kmoe kmoe merged commit 6d5e177 into hashicorp:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmoe kmoe kmoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Init() always gives -force-copy as an argument
4 participants
@chanwit @hashicorp-cla @Nalum @kmoe