Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/graph: Fix failing E2E tests #261

Merged
merged 1 commit into from
Dec 17, 2021
Merged

cmd/graph: Fix failing E2E tests #261

merged 1 commit into from
Dec 17, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Dec 14, 2021

This fixes failing E2E tests for the graph command.

@radeksimko radeksimko force-pushed the graph-remove-type-flag branch 9 times, most recently from c0a61b7 to a19b762 Compare December 14, 2021 12:11
@radeksimko radeksimko requested a review from a team December 14, 2021 12:32
@alisdair
Copy link

While graph is not a stable supported command, as far as I'm aware the -type flag is not currently deprecated. We removed support for the eval and validate graph types (which weren't useful), but you can still use plan, plan-refresh-only, plan-destroy, and apply.

(I'm just noticing that the docs for the command are out of date, and we should update those.)

@radeksimko
Copy link
Member Author

Ooops, sorry - I misread the changelog! I will remove that first commit.

@radeksimko radeksimko force-pushed the graph-remove-type-flag branch from a19b762 to 9971c05 Compare December 14, 2021 15:01
@radeksimko radeksimko changed the title cmd/graph: Remove (deprecated) type flag cmd/graph: Fix failing E2E tests Dec 14, 2021
@radeksimko radeksimko marked this pull request as ready for review December 14, 2021 15:07
@radeksimko radeksimko force-pushed the graph-remove-type-flag branch from 9971c05 to f7231ca Compare December 14, 2021 15:26
@radeksimko radeksimko merged commit 1564ef0 into main Dec 17, 2021
@radeksimko radeksimko deleted the graph-remove-type-flag branch December 17, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants