Adding Taint/Untaint command support

[rambabuiitk]

Adding output name option support

[rambabuiitk]

@radeksimko new PR

[rambabuiitk]

@radeksimko any chance I could get the review? the winbuildtest is failing, not sure why though...I couldn't find the reason from the logs...Is that mandatory?

[rambabuiitk]

@lafentres Can I get the review for this? I see the issue assigned to you.

[radeksimko]

Hi @rambabuiitk
Thanks for your contribution!

Aside from my in-line comments I will say that we aim to also more gracefully handle version differences in tfexec and taint in particular was introduced in v0.4.1 hashicorp/terraform@4ec31ec
untaint was introduced in v0.6.13 hashicorp/terraform@c7f5450

Would you therefore mind adding a version check, similar to the one we have for fmt here?

terraform-exec/tfexec/fmt.go

Lines 129 to 132 in 750bc90

	err := tf.compatible(ctx, tf0_7_7, nil)
	if err != nil {
	return nil, fmt.Errorf("fmt was first introduced in Terraform 0.7.7: %w", err)
	}

Having checks for the individual flags would also be nice to have, but I won't block the PR on those.

[radeksimko]

As for the failing Windows job I believe that's unrelated to your PR. I noticed we had a similar timeout-triggered failure on main recently: https://app.circleci.com/pipelines/github/hashicorp/terraform-exec/1334/workflows/d059b80e-43e4-4ea8-905f-165efaec939f/jobs/16081

I will look into raising the timeout in a separate PR.

[radeksimko]

Thank you for making these changes promptly.

I left you some more comments in-line.

Also - as suggested - do you mind adding each taint and untaint flag as an option?

[radeksimko]

LGTM, thanks, I'll just apply that one last minor suggestion and get it merged.