(maint) update scripts/release/release.sh #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use $(...) over `...` (backticks) because it is the legacy syntax required by only the very oldest of non-POSIX-compatible bourne-shells - remove un-used `START_DIR` variable - use `printf` bringing it up to date with the rest of the script and honors the `\n` without needing a `-e` flag.
radeksimko
reviewed
Aug 2, 2021
There was a problem hiding this comment.
Hi @vladdoster
Sorry for the delay in reviewing your PR.
The changes you propose look reasonable to me but may I ask you what motivated the PR since all these changes don't seem to fix any particular bug - unless I'm mistaken?
I should mention that we use pretty much the same script in a number of other repositories: https://github.com/search?q=org%3Ahashicorp+getTargetVersion&type=code
radeksimko
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(...)over`...`(backticks) because it is the legacy syntax required by only the very oldest of non-POSIX-compatible bourne-shellsSTART_DIRvariableprintfbringing it up to date with the rest of the script and honors the\nwithout needing a-eflag.